Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joeystern’s picture

Assigned: Unassigned » joeystern
joeystern’s picture

Assigned: joeystern » Unassigned
Status: Active » Needs review
FileSize
1.68 KB

Completed change listed here, now requires check

Status: Needs review » Needs work

The last submitted patch, drupal-Views_method-opstarts-2003510-2.patch, failed testing.

JeroenT’s picture

Status: Needs work » Needs review
FileSize
1.69 KB

rename views method op_starts() to addStartsWith().

Patch attached.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Done

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opStartsWith - I'm okay with adding the With as this makes sense.

nathangervais’s picture

Status: Needs work » Needs review
FileSize
1.68 KB

Rerolled patch to rename op_starts() to opStartsWith()

heddn’s picture

Title: Rename Views method op_starts() to addStartsWith() » Rename Views method op_starts() to opStartsWith()

Fixing title.

Status: Needs review » Needs work

The last submitted patch, drupal_rename_op_starts-2003510-7.patch, failed testing.

JeroenT’s picture

Status: Needs work » Needs review
FileSize
1.69 KB

rename op_starts() to opStartsWith().

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Seems fine.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 995e449 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.