Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#7 | views.core-change_get_aggregation_info-2002892-06.patch | 5.28 KB | tvlooy |
#6 | views-rename_get_aggregation_info-2002892-6.patch | 5.28 KB | JeroenT |
#2 | views.core-change_get_aggregation_info-2002892-02.patch | 4.52 KB | toddtomlinson |
Comments
Comment #1
toddtomlinson CreditAttribution: toddtomlinson commentedComment #2
toddtomlinson CreditAttribution: toddtomlinson commentedPatch attached to change get_aggregation_info to getAggregationInfo.
Comment #4
oenie CreditAttribution: oenie commented#2: views.core-change_get_aggregation_info-2002892-02.patch queued for re-testing.
Comment #5
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the functions to adher to the new OOP standards.
core/modules/views_ui/lib/Drupal/views_ui/Form/Ajax/ConfigItem.php, line 220:
And it seems you forgot a reference to the method in a different module.
Comment #6
JeroenTPatch attached to change get_aggregation_info to getAggregationInfo.
Comment #7
tvlooy CreditAttribution: tvlooy commentedDuplicate patch. Sorry!
Comment #8
oenie CreditAttribution: oenie commentedLooks fine to me now ! Once the patch passed testbot, it's RTBC for me.
Comment #9
heddnNo mentions of get_aggregation_info any more and applies cleanly. Passed testbot.
Comment #10
heddnNo mentions of get_aggregation_info and applies cleanly. Passed testbot.
Comment #11
alexpottCommitted b06ef6d and pushed to 8.x. Thanks!