Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 2002908-5-views-rename-methods.patch1.31 KBlokapujya
#1 views-rename-methods-2002908-1.patch1.31 KBbdone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bdone’s picture

bdone CreditAttribution: bdone commented
Status: Active » Needs review
FileSize
views-rename-methods-2002908-1.patch1.31 KB

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-rename-methods-2002908-1.patch, failed testing.

nielsonm’s picture

nielsonm CreditAttribution: nielsonm commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#1: views-rename-methods-2002908-1.patch queued for re-testing.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Needs work

Unfortunately we need a reroll, the patch doesn't apply anymore.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
CreditAttribution: lokapujya commented
Assigned: Unassigned » lokapujya
lokapujya’s picture

lokapujya
Primary language English
Location Boston
CreditAttribution: lokapujya commented
Status: Needs work » Needs review
FileSize
2002908-5-views-rename-methods.patch1.31 KB

Re-rolled.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2002908-5-views-rename-methods.patch, failed testing.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
CreditAttribution: lokapujya commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#6: 2002908-5-views-rename-methods.patch queued for re-testing.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 708e3c9 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.