Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#12 | views-core-rename-click_sortable-2002426-12.patch | 5.17 KB | SpartyDan |
#9 | drupal-rename-function-click-sortable-public-2002426-9.patch | 5.23 KB | rootwork |
#9 | interdiff.txt | 3.66 KB | rootwork |
#7 | drupal-rename-funtion-click-sortable-2002426-7.patch | 4.83 KB | rootwork |
#7 | interdiff.txt | 2.18 KB | rootwork |
Comments
Comment #1
hugo.lallo CreditAttribution: hugo.lallo commentedComment #2
hugo.lallo CreditAttribution: hugo.lallo commentedComment #3
no_angel CreditAttribution: no_angel commentedworking on the patch testing at sprint today
Comment #4
no_angel CreditAttribution: no_angel commentedI tested the patch and found the old name in these files.
in core/modules/translation_entity/lib/Drupal/translation_entity/Plugin/views/field/TranslationLink.php on line 81
in core/modules/views/lib/Drupal/views/Tests/Handler/FieldUnitTest.php on lines 527, 535 and 540
thanks to @hosef for his guidance on this testing and review.
Comment #5
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the functions to adher to the new OOP standards.
Comment #6
rootworkWorking on this.
Comment #7
rootworkRenamed the other references to the functions from #4 and added the public modifier in the two places specified in #5.
Comment #8
rootworkComment #9
rootworkSorry, ignore the last patch, somehow I still missed a couple of places.
This is a revised patch and an interdiff from #1 (not my messed up patch in #7).
Comment #10
dawehnerThis looks nearly perfect.
Let's use {@inheritdoc} here.
Comment #11
heddnComment #12
SpartyDan CreditAttribution: SpartyDan commentedmade change suggested in #10
Comment #13
aspilicious CreditAttribution: aspilicious commentedThnx!
Comment #14
alexpottCommitted eb2b412 and pushed to 8.x. Thanks!