Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#5 | rename-view-method-2002478-5.patch | 1.38 KB | Ari Gold |
#3 | rename-view-method-2002478-3.patch | 1.37 KB | Ari Gold |
#2 | rename-view-method-2002478-2.patch | 636 bytes | Ari Gold |
Comments
Comment #1
Ari Gold CreditAttribution: Ari Gold commentedComment #2
Ari Gold CreditAttribution: Ari Gold commentedPatch attached.
Comment #3
Ari Gold CreditAttribution: Ari Gold commentedRerolled patch.
Comment #4
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adher to the new OOP standards.
Comment #5
Ari Gold CreditAttribution: Ari Gold commentedRerolled patch.
Are the new OOP coding standards documented?
Comment #6
Ari Gold CreditAttribution: Ari Gold commentedI now see that comment #28 in https://drupal.org/node/1856630 suggests that public is a good default.
Comment #7
oenie CreditAttribution: oenie commentedIt kind of depends on how the function is used.
If it's a function that's only used from a class instance itself ($this->elementWrapperClasses), you could set it to protected.
But public usually is a safe bet.
Comment #8
oenie CreditAttribution: oenie commentedLooks fine now.
Comment #9
catchCommitted/pushed to 8.x, thanks!