Support from Acquia helps fund testing for Drupal Acquia logo

Comments

no_angel’s picture

Assigned: Unassigned » no_angel

working on at sprint

no_angel’s picture

Assigned: no_angel » Unassigned
aviindub’s picture

Assigned: Unassigned » aviindub
aviindub’s picture

going to attempt this as my first patch

aviindub’s picture

Status: Active » Needs review
FileSize
1.25 MB
aviindub’s picture

Assigned: aviindub » Unassigned
Xano’s picture

Status: Needs review » Needs work

The patch changes file permissions from 644 to 755. It needs a re-roll that does not change permissions. This patch was probably made using Windows. Execute git config --global core.filemode false to fix this.

tyjamessmith’s picture

Status: Needs work » Needs review
FileSize
10.13 KB

Here's the reroll. We did what Xano said. Then just rolled the patch. No other changes.

marlatt’s picture

Assigned: Unassigned » marlatt
Status: Needs review » Active

Working on this.

Xano’s picture

Assigned: marlatt » Unassigned
Status: Active » Reviewed & tested by the community

Patch changes method names. I confirm that the file modes are now untouched.

marlatt’s picture

Status: Reviewed & tested by the community » Needs review

Sorry started working same time re-roll was posted.

tyjamessmith’s picture

It was mentioned that the functions should have public explicitly expressed so I added it in and rolled the two patches together into this one.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal.camelcase_getvaloptions_2003500_12.patch, failed testing.

tyjamessmith’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, drupal.camelcase_getvaloptions_2003500_12.patch, failed testing.

marlatt’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, drupal.camelcase_getvaloptions_2003500_12.patch, failed testing.

marlatt’s picture

Assigned: Unassigned » marlatt
Status: Needs work » Active

Working..

marlatt’s picture

Assigned: marlatt » Unassigned
Status: Active » Needs review
FileSize
953 bytes
10.06 KB

Removed duplicate public access modifier.

oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed b8f18c3 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.