Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#19 | rename_views_method-2003500-19.patch | 10.06 KB | marlatt |
#19 | interdiff.txt | 953 bytes | marlatt |
#12 | drupal.camelcase_getvaloptions_2003500_12.patch | 10.07 KB | tyjamessmith |
#8 | 2003500_reroll_for_mode.patch | 10.13 KB | tyjamessmith |
#5 | drupal_views-rename_get_value_options-2003500.patch | 1.25 MB | aviindub |
Comments
Comment #1
no_angel CreditAttribution: no_angel commentedworking on at sprint
Comment #2
no_angel CreditAttribution: no_angel commentedComment #3
aviindub CreditAttribution: aviindub commentedComment #4
aviindub CreditAttribution: aviindub commentedgoing to attempt this as my first patch
Comment #5
aviindub CreditAttribution: aviindub commentedComment #6
aviindub CreditAttribution: aviindub commentedComment #7
XanoThe patch changes file permissions from 644 to 755. It needs a re-roll that does not change permissions. This patch was probably made using Windows. Execute
git config --global core.filemode false
to fix this.Comment #8
tyjamessmith CreditAttribution: tyjamessmith commentedHere's the reroll. We did what Xano said. Then just rolled the patch. No other changes.
Comment #9
marlatt CreditAttribution: marlatt commentedWorking on this.
Comment #10
XanoPatch changes method names. I confirm that the file modes are now untouched.
Comment #11
marlatt CreditAttribution: marlatt commentedSorry started working same time re-roll was posted.
Comment #12
tyjamessmith CreditAttribution: tyjamessmith commentedIt was mentioned that the functions should have public explicitly expressed so I added it in and rolled the two patches together into this one.
Comment #14
tyjamessmith CreditAttribution: tyjamessmith commented#12: drupal.camelcase_getvaloptions_2003500_12.patch queued for re-testing.
Comment #16
marlatt CreditAttribution: marlatt commented#12: drupal.camelcase_getvaloptions_2003500_12.patch queued for re-testing.
Comment #18
marlatt CreditAttribution: marlatt commentedWorking..
Comment #19
marlatt CreditAttribution: marlatt commentedRemoved duplicate public access modifier.
Comment #20
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #21
alexpottCommitted b8f18c3 and pushed to 8.x. Thanks!