Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Rename Views method add_having_expression() to addHavingExpression()
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comments
Comment #2
juan.brein CreditAttribution: juan.brein commentedHope you don't mind if I take this one. Starting to submit patches and I found this one pretty easy one.
My patch is attached
cheers
Juan
Comment #3
dawehnerPlease make it public
Comment #4
juan.brein CreditAttribution: juan.brein commentedSorry don't quite understand what this last comment mean. Do you want me to apply this snippet and put the patch again?
Comment #5
elvis2 CreditAttribution: elvis2 commented@juan, he means to make this:
function addHavingExpression($group, $snippet, $args = array()) {
to
public function addHavingExpression($group, $snippet, $args = array()) {
Comment #6
oenie CreditAttribution: oenie commentedduplicate comment - safely ignore this :)
Comment #7
KCarlile CreditAttribution: KCarlile commentedRenamed add_having_expression() to addHavingExpression() and made it public.
Comment #8
zschmid CreditAttribution: zschmid commentedadding public function
Comment #10
zschmid CreditAttribution: zschmid commented#8: views-add_having_expression-rename-2001330.patch queued for re-testing.
Comment #11
KCarlile CreditAttribution: KCarlile commentedHmm...I'm not sure why this patch failed. It's nearly identical to the previous one that passed, except for the "public" declaration. I'm very new to this (as in just started at Drupalcon today), so would anyone be able to help explain why this test failed? Thanks!
Comment #12
elvis2 CreditAttribution: elvis2 commented@KCarlile, I believe the test bots or the git server (d.o) is having issues. You can get more details on the failure by clicking on "view details" link to the right of the status.
When clicking on the last patch details, near the bottom of the page you will see:
[23:05:03] Encountered error on [checkout], details:
array (
'@reason' => 'failed to checkout from [git://git.drupal.org/project/drupal.git]',
)
That indicates the drupal.git project can not be checked out, for some reason. Hopefully the problem will dissipate soon.
Comment #13
juan.brein CreditAttribution: juan.brein commentedNew patch
Comment #15
zschmid CreditAttribution: zschmid commentedComment #16
juan.brein CreditAttribution: juan.brein commented#13: views-add_having_expression-rename-2001330.patch queued for re-testing.
Comment #17
aspilicious CreditAttribution: aspilicious commentedLooks good
Comment #18
KCarlile CreditAttribution: KCarlile commented#7: views-add_having_expression-rename.patch-7.patch queued for re-testing.
Comment #19
elvis2 CreditAttribution: elvis2 commentedAll good. Reviewed patch based on: http://drupal.org/node/1856630#comment-7450696
Comment #20
alexpottCommitted b53df3c and pushed to 8.x. Thanks!
Comment #21
alexpottComment #22.0
(not verified) CreditAttribution: commentedCopied directly from core.drupalofficehours.org