Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, views-add_having_expression-rename.patch, failed testing.

juan.brein’s picture

Assigned: chertzog » juan.brein
Status: Needs work » Needs review
FileSize
5.38 KB

Hope you don't mind if I take this one. Starting to submit patches and I found this one pretty easy one.

My patch is attached

cheers

Juan

dawehner’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -953,7 +953,7 @@ function add_having($group, $field, $value = NULL, $operator = NULL) {
+  function addHavingExpression($group, $snippet, $args = array()) {

Please make it public

juan.brein’s picture

Sorry don't quite understand what this last comment mean. Do you want me to apply this snippet and put the patch again?

elvis2’s picture

@juan, he means to make this:

function addHavingExpression($group, $snippet, $args = array()) {

to

public function addHavingExpression($group, $snippet, $args = array()) {

oenie’s picture

Status: Needs review » Needs work

duplicate comment - safely ignore this :)

KCarlile’s picture

Status: Needs work » Needs review
FileSize
5.38 KB

Renamed add_having_expression() to addHavingExpression() and made it public.

zschmid’s picture

adding public function

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-add_having_expression-rename-2001330.patch, failed testing.

zschmid’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
KCarlile’s picture

Hmm...I'm not sure why this patch failed. It's nearly identical to the previous one that passed, except for the "public" declaration. I'm very new to this (as in just started at Drupalcon today), so would anyone be able to help explain why this test failed? Thanks!

elvis2’s picture

@KCarlile, I believe the test bots or the git server (d.o) is having issues. You can get more details on the failure by clicking on "view details" link to the right of the status.

When clicking on the last patch details, near the bottom of the page you will see:

[23:05:03] Encountered error on [checkout], details:
array (
'@reason' => 'failed to checkout from [git://git.drupal.org/project/drupal.git]',
)

That indicates the drupal.git project can not be checked out, for some reason. Hopefully the problem will dissipate soon.

juan.brein’s picture

Status: Needs review » Needs work

The last submitted patch, views-add_having_expression-rename-2001330.patch, failed testing.

zschmid’s picture

Assigned: zschmid » Unassigned
Status: Needs work » Needs review
juan.brein’s picture

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Looks good

KCarlile’s picture

elvis2’s picture

All good. Reviewed patch based on: http://drupal.org/node/1856630#comment-7450696

alexpott’s picture

Status: Fixed » Reviewed & tested by the community

Committed b53df3c and pushed to 8.x. Thanks!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Copied directly from core.drupalofficehours.org