Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#7 | rename-views-method-click-sort-2002424-7.patch | 1.85 KB | web.dev.cas |
#6 | rename-views-method-click-sort-2002424-6.patch | 1.85 KB | web.dev.cas |
#4 | 2002424-rename-views-method-part2.patch | 1.84 KB | web.dev.cas |
#2 | 2002424-rename-views-method.patch | 1.24 KB | web.dev.cas |
Comments
Comment #1
web.dev.cas CreditAttribution: web.dev.cas commentedWorking on this as part of core code sprint.
Comment #2
web.dev.cas CreditAttribution: web.dev.cas commentedReplaced two instances of click_sort() with clickSort().
Comment #3
web.dev.cas CreditAttribution: web.dev.cas commentedForgot to set status to needs review.
Comment #4
web.dev.cas CreditAttribution: web.dev.cas commentedI missed an instance of click_sort(). Attaching new complete patch.
Comment #5
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the functions to adher to the new OOP standards.
Comment #6
web.dev.cas CreditAttribution: web.dev.cas commentedAdded public access modifier to clickSort functions. Thanks, oenie!
Comment #7
web.dev.cas CreditAttribution: web.dev.cas commentedThe status of the last patch was stuck in "Test request sent" comment display, but on inspecting details, I saw that it in fact failed system test. Resubmitting new version of patch based upon latest repo pull.
Comment #9
web.dev.cas CreditAttribution: web.dev.cas commented#7: rename-views-method-click-sort-2002424-7.patch queued for re-testing.
Comment #10
web.dev.cas CreditAttribution: web.dev.cas commentedThe re-test of patch #7 passed. This issue needs community review.
Comment #11
heddnLooks good.
Comment #12
alexpottCommitted 51d364e and pushed to 8.x. Thanks!