Rename Views method element_wrapper_classes() to elementWrapperClasses() [#2002478]

Comment	File	Size	Author
#5	rename-view-method-2002478-5.patch	1.38 KB	Ari Gold

#3	rename-view-method-2002478-3.patch	1.37 KB	Ari Gold

#2	rename-view-method-2002478-2.patch	636 bytes	Ari Gold

Comment #1

Ari Gold CreditAttribution: Ari Gold commented 24 May 2013 at 18:03

Assigned:

Unassigned

» Ari Gold

Log in or register to post comments

Comment #2

Ari Gold CreditAttribution: Ari Gold commented 24 May 2013 at 18:25

Status:

Active

» Needs review

File	Size
rename-view-method-2002478-2.patch	636 bytes

Patch attached.

Log in or register to post comments

Comment #3

Ari Gold CreditAttribution: Ari Gold commented 24 May 2013 at 19:08

File	Size
rename-view-method-2002478-3.patch	1.37 KB

Rerolled patch.

Log in or register to post comments

Comment #4

oenie CreditAttribution: oenie commented 24 May 2013 at 22:46

Status:

Needs review

» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -349,7 +349,7 @@ function element_label_classes($row_index = NULL) {
+  function elementWrapperClasses($row_index = NULL) {

Add public access modifier in front of the function to adher to the new OOP standards.

Log in or register to post comments

Comment #5

Ari Gold CreditAttribution: Ari Gold commented 24 May 2013 at 23:50

Status:

Needs work

» Needs review

File	Size
rename-view-method-2002478-5.patch	1.38 KB

Rerolled patch.

Are the new OOP coding standards documented?

Log in or register to post comments

Comment #6

Ari Gold CreditAttribution: Ari Gold commented 25 May 2013 at 00:03

I now see that comment #28 in https://drupal.org/node/1856630 suggests that public is a good default.

Log in or register to post comments

Comment #7

oenie CreditAttribution: oenie commented 25 May 2013 at 00:56

It kind of depends on how the function is used.
If it's a function that's only used from a class instance itself ($this->elementWrapperClasses), you could set it to protected.
But public usually is a safe bet.