Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#21 | drupal-viewsRename-get_field-2002910-21.patch | 15.05 KB | heddn |
#18 | Rename-Views-method-get_field-to-getField-2002910-18.patch | 19.37 KB | diarmy |
#18 | interdiff.txt | 4.61 KB | diarmy |
#14 | Rename-Views-method-get_field-to-getField-2002910-14.patch | 13.36 KB | diarmy |
#14 | interdiff.txt | 3.82 KB | diarmy |
Comments
Comment #1
toddtomlinson CreditAttribution: toddtomlinson commentedComment #2
toddtomlinson CreditAttribution: toddtomlinson commentedReplaced get_file with getFile across several views.core files. Patch attached.
Comment #3
dbcollies CreditAttribution: dbcollies commentedComment #5
dbcollies CreditAttribution: dbcollies commentedI believe there to be a bug in the test, not in the code submitted in comment #3. The test fails randomly, with no change in the code
Comment #6
toddtomlinson CreditAttribution: toddtomlinson commented#2: views.core-replace_get_file_with_getfile-2002910-02.patch queued for re-testing.
Comment #7
dbcollies CreditAttribution: dbcollies commentedI think the patch in comment #2 (and I apologize that I didn't notice you had taken this task before I made my patch) is missing changes to the following two files:
I suspect the second one is what's causing the failure in
HandlerFieldFieldTest
. I'm convinced that it's something outside of either of these patches that's causing theBlockRenderOrderTest
random failureComment #8
dbcollies CreditAttribution: dbcollies commented#3: Rename-Views-method-get_field-to-getField-2002910-1.patch queued for re-testing.
Comment #10
oenie CreditAttribution: oenie commented#3: Rename-Views-method-get_field-to-getField-2002910-1.patch queued for re-testing.
Comment #11
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adher to the new OOP standards.
Comment #12
diarmy CreditAttribution: diarmy commentedAdded public access modifier to getField function in RssFields class as recommended in #11
Comment #14
diarmy CreditAttribution: diarmy commentedUpdated instances of get_field() in HandlerFieldFieldTest.
Comment #15
diarmy CreditAttribution: diarmy commentedUpdating status to needs review.
Comment #16
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #17
alexpottSeems like we've added a new one in Drupal\contextual\Plugin\views\field\ContextualLinks
Comment #18
diarmy CreditAttribution: diarmy commentedReplaced more instances of get_field() with getField()
Comment #19
diarmy CreditAttribution: diarmy commentedComment #20
dawehnerOut of scope for this issue.
Comment #21
heddnLet's see if this makes the testbot happy.
Comment #22
heddnComment #23
dawehnerAwesome!
Comment #24
oenie CreditAttribution: oenie commentedLooks good to me !
Comment #25
alexpottCommitted b48343a and pushed to 8.x. Thanks!