It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.
Related to the Views in Drupal Core initiative.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Taking this with baldwinlouie.
Patch attached.
The last submitted patch, 2003484-rename-get_token_values_recursive.patch, failed testing.
#2: 2003484-rename-get_token_values_recursive.patch queued for re-testing.
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined @@ -1537,7 +1537,7 @@ function get_render_tokens($item) { + function getTokenValuesRecursive(array $array, array $parent_keys = array()) {
Add protected access modifier in front of the function to adhere to the new OOP standards.
If the above is fixed, the patch is ok and ready for RTBC.
Re-rolled with protected.
Looks good to me now !
Adding VDC tag.
Committed df13368 and pushed to 8.x. Thanks!
Automatically closed -- issue fixed for 2 weeks with no activity.
Comments
Comment #1
sillygwailoTaking this with baldwinlouie.
Comment #2
sillygwailoPatch attached.
Comment #4
sillygwailo#2: 2003484-rename-get_token_values_recursive.patch queued for re-testing.
Comment #5
oenie CreditAttribution: oenie commentedAdd protected access modifier in front of the function to adhere to the new OOP standards.
If the above is fixed, the patch is ok and ready for RTBC.
Comment #6
sillygwailoRe-rolled with protected.
Comment #7
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #8
jibranAdding VDC tag.
Comment #9
alexpottCommitted df13368 and pushed to 8.x. Thanks!