Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Comments
Comment #1
cecrs CreditAttribution: cecrs commentedComment #2
cecrs CreditAttribution: cecrs commentedComment #3
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedComment #4
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedA first stab at this.
Comment #5
vijaycs85#4: 1987758-node-access-test-page-controller-1.patch queued for re-testing.
Comment #6
dawehnerIt seems to be an INSANE idea to have a page to show the database query, so you can check it in your test, but yeah let's open a follow up to use a better approach.
Technically we don't remove the hook_menu entry if it is not a MENU_CALLBACK, but this is just about checking the page output.
Comment #7
alexpottIt is totally insane to do the test this way.
Lets remove hook_menu, page callback and testNodeQueryAlterWithUI as this test is repeated with the low level tests.
Comment #8
juampynr CreditAttribution: juampynr commentedHere you are.
Comment #9
dawehnerThere is not only node_access_test_page but also node_access_entity_test_page so maybe we should get rid of that one as well.
Comment #10
juampynr CreditAttribution: juampynr commentedSure! Closed #1987756: Remove node_access_entity_test_page().
Here is a patch which gets rid of both.
Comment #11
ParisLiakos CreditAttribution: ParisLiakos commentedgood riddance
Comment #12
alexpottCommitted 30a45ad and pushed to 8.x. Thanks!
Comment #14
BerdirThis removed the only test method in that test, which means that it now spits out FATAL messages in the CLI test runner and the UI breaks: #2056293: Remove empty test Drupal\node\Tests\NodeEntityFieldQueryAlterTest