Part of #1971384: [META] Convert page callbacks to controllers and #2003892: Convert date formats to config entities

CommentFileSizeAuthor
#4 date-format-2003942-4.patch18.89 KBtim.plunkett
#3 date-format-2003942-3.patch19.64 KBtim.plunkett
#3 interdiff.txt6.41 KBtim.plunkett
#1 date-format-2003942-1.patch18.15 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
FileSize
date-format-2003942-1.patch18.15 KB

Okay, here's the first pass.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented 
+++ b/core/modules/system/lib/Drupal/system/Form/DateFormatEditForm.phpundefined
@@ -0,0 +1,103 @@
+    $format_info = config('system.date')->get('formats.' . $date_format_id);

Well at least inject it.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
interdiff.txt6.41 KB
date-format-2003942-3.patch19.64 KB

This contains the fix from #1909418: Allow Entity Controllers to have their dependencies injected for now.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
date-format-2003942-4.patch18.89 KB

That went in, this is done I think.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/system/lib/Drupal/system/Form/DateFormatFormBase.phpundefined
@@ -0,0 +1,71 @@
+    $date = new DrupalDateTime();

So apparently there is already an issue to make this a service, so that's cool.

Manually tesed and reviewed. Can't find anything wrong with this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 291689a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.