Support from Acquia helps fund testing for Drupal Acquia logo

Comments

baldwinlouie’s picture

Assigned: Unassigned » baldwinlouie
baldwinlouie’s picture

taking it with sillygwailo

baldwinlouie’s picture

Status: Active » Needs review
FileSize
1.15 KB

attaching patch

Status: Needs review » Needs work

The last submitted patch, drupal-camelcase-replace-2003476-7451294.patch, failed testing.

oenie’s picture

All occurrences replaced; fix the issue below and it can be marked RTBC !

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.phpundefined
@@ -160,7 +160,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function getTemporaryView() {

Add protected access modifier in front of the function to adhere to the new OOP standards.

baldwinlouie’s picture

Status: Needs work » Needs review
FileSize
1.16 KB

changed access modifier to protected. Re-rolled patch

oenie’s picture

Looks fine to me now ! Once the patch passed testbot, it's RTBC for me.

oenie’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -VDC

Committed 0a563e8 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.