Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Comment | File | Size | Author |
---|---|---|---|
#14 | 1987894-user-logout-route-14.patch | 6.75 KB | ParisLiakos |
#10 | 1987894-user-logout-route-10.patch | 6.88 KB | ParisLiakos |
#10 | interdiff.txt | 2.34 KB | ParisLiakos |
#9 | 1987894-user-logout-route-9.patch | 6.4 KB | ParisLiakos |
#9 | interdiff.txt | 1.71 KB | ParisLiakos |
Comments
Comment #1
vijaycs85Initial patch...
Comment #3
ParisLiakos CreditAttribution: ParisLiakos commentedComment #4
ParisLiakos CreditAttribution: ParisLiakos commentedalso..
Comment #5
ParisLiakos CreditAttribution: ParisLiakos commentedmeh..this wont fire hooks..something a bit uglier then
Comment #6
ParisLiakos CreditAttribution: ParisLiakos commentedhumpff, wrong namespace
Comment #7
Crell CreditAttribution: Crell commentedThis seems very wrong... You should never send() the response yourself.
Comment #8
ParisLiakos CreditAttribution: ParisLiakos commentedi know its ugly like i said in #5 but i am open to alternatives!
hmm maybe i should keep user_logout() and fix this in another issue
Comment #9
ParisLiakos CreditAttribution: ParisLiakos commentedthere, lets keep this issue moving, cause this access check here is needed to several other conversions and fixing openid for drupal_exit removal
Comment #10
ParisLiakos CreditAttribution: ParisLiakos commentedWebTestBase--
Comment #12
ParisLiakos CreditAttribution: ParisLiakos commentedcant reproduce locally
#10: 1987894-user-logout-route-10.patch queued for re-testing.
Comment #13
dawehnerDo we really need this statement? I can't see any usage.
Renaming an existing file feels a bit unrelated though this could make sense.
Comment #14
ParisLiakos CreditAttribution: ParisLiakos commentedthanks for the review!
this conflicted with roles commit, so no interdiff, sorry.
i removed the unneeded use statement
yes i moved cause i just created the directory, i dont think we should have a seperate issue for moving this
Comment #15
Crell CreditAttribution: Crell commentedWhy exactly aren't we removing user_logout(), the function?
Comment #16
ParisLiakos CreditAttribution: ParisLiakos commentedbecause it is needed by user_menu_site_status_alter
it does something hacky, and imo should be converted to an event listener. you cant redirect like that, but fixing this should happen in the RedirectResponse issue
Comment #17
dawehnerGreat, thank you.
Comment #18
ParisLiakos CreditAttribution: ParisLiakos commentedCrell opened a nice followup for #15, #16
#1998228: Remove hook_menu_site_status_alter() in favor of request listeners
Comment #19
alexpottCommitted e21c1a1 and pushed to 8.x. Thanks!
Comment #20
alexpott