Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gdf’s picture

Assigned: Unassigned » gdf
gdf’s picture

Status: Active » Needs review
FileSize
1.47 KB
gdf’s picture

forgot to add "public" to method

gdf’s picture

changed "publi" to "public", note to myself not to borrow cheesy mac from friend next DrupalCon

munizjor’s picture

Status: Needs review » Reviewed & tested by the community

Ran successful test creating a view.

pbuyle’s picture

I did not find any occurrence of the store_group_input in core after applying the patch in #4.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-store-group-input-2003240-2.patch, failed testing.

pbuyle’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
gdf’s picture

Assigned: gdf » Unassigned

retest was successful - code is not related, and it was a very, very busy day for testBot

oenie’s picture

Status: Needs review » Needs work

Unfortunately we need a reroll, the patch doesn't apply anymore.

theladebug’s picture

Status: Needs work » Needs review
FileSize
1.48 KB

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, renamed-store-group-input-2003240-11.patch, failed testing.

theladebug’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
aspilicious’s picture

Status: Needs review » Needs work

You need to reroll your patch i don't think it applies anymore. (due to all the views patches getting in)

theladebug’s picture

Status: Needs work » Needs review
FileSize
1.48 KB

rerolled patch

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Great!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 5e0590c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.