Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#19 | views-core-rename-sort-options-2003246-19.patch | 1.05 KB | nathangervais |
#19 | interdiff.txt | 717 bytes | nathangervais |
#16 | interdiff.txt | 717 bytes | nathangervais |
#16 | views-core-rename-sort-options-2003246-13.patch | 1.04 KB | nathangervais |
#14 | views-core-rename-sort-options-2003246-13.patch | 1.04 KB | SpartyDan |
Comments
Comment #1
farfanfelipe CreditAttribution: farfanfelipe commentedComment #2
SlayJay CreditAttribution: SlayJay commentedComment #3
SlayJay CreditAttribution: SlayJay commentedComment #4
SlayJay CreditAttribution: SlayJay commentedComment #5
SlayJay CreditAttribution: SlayJay commentedrenamed function names.
Comment #6
SlayJay CreditAttribution: SlayJay commentedComment #7
SlayJay CreditAttribution: SlayJay commentedforgot to add public.
Comment #8
hoZt CreditAttribution: hoZt commentedLooks good.
Comment #10
SlayJay CreditAttribution: SlayJay commented#7: 2003246-7449576-2.patch queued for re-testing.
Comment #11
oenie CreditAttribution: oenie commentedUnfortunately we need a reroll, the patch doesn't apply anymore.
Comment #12
SpartyDan CreditAttribution: SpartyDan commentedre-rolled
Comment #14
SpartyDan CreditAttribution: SpartyDan commentedpatch 12 no longer applies.
re-rolled
Comment #15
aspilicious CreditAttribution: aspilicious commentedShould be protected
=> protected function sortOptions() {
Comment #16
nathangervais CreditAttribution: nathangervais commentedHere's the old patch with an interdiff to add the protected access modifier.
Comment #17
aspilicious CreditAttribution: aspilicious commentedPatch odesn't contain the access modifier
Comment #18
dcam CreditAttribution: dcam commentedIt looks like the same patch from #13 was mistakenly re-uploaded.
Comment #19
nathangervais CreditAttribution: nathangervais commentedApologies I had thought i was supposed to supply the original patch with the interdiff. Here's the new patch with the interdiff.
Comment #20
dcam CreditAttribution: dcam commentedIt's no problem. The interdiff just shows the change you made between the old patch and the new one so that it's easy for reviewers to see the changes that you've made.
Comment #21
dawehnerPerfect!
Comment #22
alexpottCommitted eb60f6f and pushed to 8.x. Thanks!