Add tests for block, menu, vocabulary and views listings

#1998600: Block config translation fails also needs test coverage yeah. We can write those tests here at once I think. I believe we only test views translatability and not all of the UI steps there either in the navigation chain.

This patches confuse me. Because they are not applicable. Could anybody filter the content of the issue and clarify the task?

Test did not pass.
http://privatepaste.com/1d970ed9aa

Does this work manually?

Manualy. It works.

Nice work! One thing to keep in mind is that the minimal profile and the testing profile are two different profiles.

A few suggestions:

1. +++ b/lib/Drupal/config_translation/Tests/ConfigTranslationListUITest.phpundefined
   @@ -0,0 +1,154 @@
   +    // Test if Translate appears anywhere on the page.
   +    $this->assertText($translate_operation_title);
   ...
   +    // Simple test for 'Translate' anywhere on the taxonomy list page.
   +    $this->drupalGet($list_url);
   +    $this->assertText($translate_operation_title);
   

   This assertion is probably redundant now that we have the check for the translate link.

2. +++ b/lib/Drupal/config_translation/Tests/ConfigTranslationListUITest.phpundefined
   @@ -0,0 +1,154 @@
   +    $translate_link = 'admin/structure/block/manage/stark.' . $block_machine_name . '/translate';
   +    // Test if the link to translate the block is on the page.
   +    $this->assertLinkByHref($translate_link);
   

   This assertion is the core of what we want to test -- looks good!

3. +++ b/lib/Drupal/config_translation/Tests/ConfigTranslationListUITest.phpundefined
   @@ -0,0 +1,154 @@
   +    // Create a test menu to decouple looking for Translate operations
   +    // link so this does not test more than necessary.
   +    $this->drupalGet('admin/structure/menu/add');
   +    // Lowercase the machine name. Find the issue that is supposed to be making
   +    // randomMachineName().
   +    $menu_name = drupal_strtolower($this->randomName(16));
   +    $label = $this->randomName(16);
   +    $edit = array(
   +      'id' => $menu_name,
   +      'description' => '',
   +      'label' =>  $label,
   +    );
   +    $this->drupalPost('admin/structure/menu/add', $edit, t('Save'));
   

   Once this is working (I think it is?), a good next step would be to create the menu link programmatically instead of with drupalPost(). (Similarly for the vocabulary.)

4. +++ b/lib/Drupal/config_translation/Tests/ConfigTranslationListUITest.phpundefined
   @@ -0,0 +1,154 @@
   +    // Views 'admin/structure/views'.
   +    // Frontpage view is enabled in test minimal profile, so do not need to add
   +    // a test view.
   +    $list_url = 'admin/structure/views';
   

   So, it's bad practice to rely on default anything provided by the testing profile. We always want a decoupled test implementation.

   In this case, this couples the test to both the Node module and the Frontpage view. See #1541298: Remove Node module dependency from Testing profile.

   So, instead, I'd suggest putting this in a separate test that uses one of the Views' modules base classes and test views.

The test was stuck, so I cancelled and requeued it.

#25: test_all_lists-2004710-25.patch queued for re-testing.

I've got time to work with this task. I am working with Kyiv Drupal initiative.

Working on this now.

Moved the single test to do*ListTest() function to have a better structured test and not everything in this single function. Moved the views test to a new Test which extends the UITestBase.

The test is now working, except the new View test. I'm currently trying to figure out how it works.
But 1., 3. and 4. from #26 should be fixed.

Still lots of other Tests are marked as todo.

Set to needs review.

View Test works now.
Minor cleanup with comments.
More tomorrow.

As always forgot status change...

I agree that the test to land now would be useful. Thanks, committed! We may want to work on a followup or more followups to complete the coverage.

Retitled for what was achieved. I think continuing in #2019831: people and roles page broken would be good, adding tests for roles to verify the before/after break/pass of that patch. I asked @kfritsche to work on that next.

Follow up for the remaining tests: #2027587: Add tests for custom blocks, contact forms, formats, shortcut listings and settings pages.

I have problems wih the test. I am resolving this issue. https://drupal.org/node/1978916.
I receive a lot of test errors that are not related with my task. Could anybody make some specifications? Where should I move? I understand I need correct tests. But, there are many tests. I do not know where to start.