Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
this does not work with the sky theme, it does not refresh the blog at all.
regards dave
Comment | File | Size | Author |
---|---|---|---|
#27 | block_refresh_theme_fix-881046-27.patch | 5.19 KB | tripper54 |
#23 | block_refresh-7.x-2.x.block_id.patch | 4.17 KB | Anybody |
#20 | block_refresh.block_id.patch | 3.05 KB | NewZeal |
Comments
Comment #1
bocaj CreditAttribution: bocaj commentedChanged title to be more descriptive
Hi Dave,
I have confirmed your issue. It appears to be an issue with block.tpl.php, which can be found in [sky_root_directory]/templates/overrides by default. I changed out the entire content of that file with the content of the same file from the aquia_marina theme. After doing this Block Refresh worked as expected.
However, this change did change the styling of the blocks in the Sky theme, beware of that. I will look into this some more and see if I can find out exactly what in the Sky's block.tpl.php file is causing the issue. This will hopefully be a workaround for now though.
Thanks for using (or attempting to use) the module!
Comment #2
bocaj CreditAttribution: bocaj commentedI have searched this issue further and have narrowed it down to the id that is set for the block. Most themes declare the id for a block in the following format:
block-views-trail_blocks-block_2
The Sky theme declares the id like so:
block-views-trail-blocks-block-2
Notice the - instead of _ after 'trail' and after 'block'. That is the issue that is causing Block Refresh not to work with the Sky theme.
After doing some quick testing it appears that if you change line 12 in block.tpl.php of the Sky theme to:
<div id="block-<?php print $block->module .'-'. $block->delta; ?>" <?php print $block_attributes; ?>>
it appears like that enables Block Refresh to work properly. Overriding the block template and keeping the default block.tpl.php in place would be the best practice so that any updates to the Sky theme doesn't overwrite any changes.
Hope this helps! Marking as won't fix as all (10) other themes I tested used the expected block id format.
Please reopen this issue if there are other themes that appear to have this same issue.
Comment #3
Ankit Srivastava CreditAttribution: Ankit Srivastava commentedHi,
I am using the theme drupal_theme_63 and i have a block residing in the banner 3 region which i need to refresh every 30 seconds or so.. but im not able to get this to work. I tried the above fix but it didnt seem to refresh the block still.
I also went through the issue queue and tried checking the "$_SERVER['REQUEST_URI'] path and it is also not getting changed which means the block is not refreshing at all.
Could you please have a look at this if possible as i would totally appreciate it..
Thanks in advance.
Comment #4
bocaj CreditAttribution: bocaj commentedHi Ankit,
I am unable to find any reference to drupal_theme_63 anywhere. Could you send me a link to the web page that has Block Refresh currently enabled, but not working? You can send me a private contact message here.
I would be happy to look into this more for you!
Comment #5
Ankit Srivastava CreditAttribution: Ankit Srivastava commentedHi,
Thanks for the awesomely quick response in solving this for me...Its fixed now and working like a charm.
I love the Drupal community...
Ankit
Comment #6
bocaj CreditAttribution: bocaj commented@Ankit I am glad to hear that you were able to fix this issue and that it is running properly now.
For the Community: The issue was again the id in the div tag for the block. I will provide better documentation for this in future releases of Block Refresh as this has cropped up many times. Also, there was an issue with an unrelated javascript function that was not functioning properly.
Also, thanks to everyone who makes Drupal the awesome community that it is!!
This is how we make the community grow and become even better...one person at a time!
Comment #7
bocaj CreditAttribution: bocaj commentedChanging the title of this issue since there are multiple themes that are not constructed the way that Block Refresh is expecting. Please post any issues related to those above in this queue!
Comment #8
eclauset CreditAttribution: eclauset commentednot sure if this is theme-related, but I have a block that is not refreshing in Firefox. It seems to work fine in Safari, and I haven't had a chance to test other browsers.
http://www.wxyc.org/
the block is the one with live playlists in the upper right, "Now Playing"
Comment #9
bocaj CreditAttribution: bocaj commented@eclauset It does appear the the block is not refreshing in Firefox 3.6.10 or IE8. I'm not sure exactly how your content in the block is being built, but I see through Firebug that Block Refresh is firing appropriately (as well as recent.html). It appears that at this point the module is working properly. Possibly a missing HTML tag or something somewhere?
I would make a separate, simple block with like a random number generator from php or something and see if that works. If so, then the issue has to be within the "Now Playing" block somewhere.
Let me know if I can help you any more!
Comment #10
pilotget CreditAttribution: pilotget commentedI am experiencing the same problem. Block refresh works on Safari, but not on IE or FF. How was this problem ultimately solved?
UPDATE: I found the problem. I had not granted "access block refresh content" to anonymous users. Since I was logged in on Safari, it worked, but it would not refresh on IE and FF, where I was not logged in... Pretty dumb on my part, but I'm confessing to my blunder in the hopes that it can help someone else.
Comment #11
stplanken CreditAttribution: stplanken commentedIt wasn't working for me either even though Firebug proved that the refresh itself appeared to be working. I found the problem: I am using a theme that is (1) not using a block ID at all and (2) uses a class of "blockcontent" for the block's content, instead of the standard "content".
As soon as I added the block ID as described earlier here and added the "content" class (even though I am not using it anywhere) the auto refresh started working. (Of course, the permission needs to be set as well.)
Hopefully it will help someone.
Comment #12
jurgenhaasI ran into the same problem here. I think D7 is using the class "block-content" instead of "content" by default and I would suggest to use the block-content class for the JQuery selector in this module instead. I'm sure it would avoid some headaches out there.
Comment #13
jide CreditAttribution: jide commented#1271938: Does not work with block deltas having underscores, behaviors not reattached on refresh complete, and other issues. fixes issues with underscores in block ids.
Comment #14
deme18 CreditAttribution: deme18 commentedHas anyone gotten this to work with the Pixture Reloaded theme, I have followed post #2 and even tried using the Block Theme module to change witch theme the block uses with no results. Any help would be appreciated.
Comment #15
ipsec CreditAttribution: ipsec commentedSame problem with AT Commerce 7.x-2.0-rc2 theme.
After block refresh I got a empty block.
Comment #16
alexpsfti CreditAttribution: alexpsfti commentedDoesn't work with AT Core + Pixture Reloaded theme. Any help would be greatly appreciated.
Comment #17
sol0matrix80 CreditAttribution: sol0matrix80 commentedPlease can anyone write a step by step on how to get this to work with themes for none devs i am a designer and i would love to use this module for sites i am making
Comment #18
sol0matrix80 CreditAttribution: sol0matrix80 commentedSystem info: drupal 7.21 theme precision 7.1x dev block refresh 7.2x dev with panels
Comment #19
jhelou CreditAttribution: jhelou commentedI am using "Corporate Clean" theme and i verified that the block id is set with "-" instead of "_" . but when i ran a grep to find out where the block id was being assigned it came back as being in Drupal core module "Dashboard". totally independent from the theme...
Also the line
print $block_attributes;
> is not changing "-" to "_" is this a typo?thank you for your help
UPDATE: i figured out that the problem is a conflict between modal forms and refresh block. i am posting this as a new issue.
Comment #20
NewZeal CreditAttribution: NewZeal commentedThis problem is caused by the way in which drupal by default displays the block id. In block.module in the function template_preprocess_block() the block name is processed via a function called drupal_html_id() which converts underscores into dashes. This id is then outputted in the block.tpl as the variable $block_html_id. For maximum compatibility between the block_refresh module and themes, the same function should be used in the block_refresh module.
There is a patch attached which fixes this incompatibility.
Comment #21
linksync CreditAttribution: linksync commentedHi New Zeal,
What version is your patch for? When I run the patch it fails on all but two of the updates.
Are you able to supply the patched working block_refresh.module file?
Thanks.
Comment #22
jhelou CreditAttribution: jhelou commented7.x
Comment #23
AnybodyThe patch works great and fixes the problems. I've attached a new version agains the LATEST 2.x DEV!
Please apply it to the latest .dev asap =)
Thanks a lot for this great module!
Comment #24
tripper54 CreditAttribution: tripper54 commentedComment #25
tripper54 CreditAttribution: tripper54 commentedCommitted to 7x.-2.x , thanks!
Comment #26
tripper54 CreditAttribution: tripper54 commentedNeeds backport to 7.x-1.x
Comment #27
tripper54 CreditAttribution: tripper54 commentedComment #28
tripper54 CreditAttribution: tripper54 commentedCommitted to 7x.-1.x
Comment #29
tripper54 CreditAttribution: tripper54 commented