Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#22 | 2002972-22.patch | 6.6 KB | jibran |
#19 | 2002972-19-rename-views-method.patch | 6.56 KB | lokapujya |
#13 | 2002972-13-rename-views-method.patch | 7.44 KB | elvis2 |
#12 | 2002972-rename-views-method_12.patch | 6.55 KB | tvlooy |
#6 | 2002972-rename-views-method.patch | 6.54 KB | lokapujya |
Comments
Comment #1
lokapujyaComment #2
lokapujyaDrupal Portland Code Sprint!
Comment #3
lokapujyaComment #4
munizjor CreditAttribution: munizjor commentedPatch is 0 bytes.
Comment #5
mcpuddin CreditAttribution: mcpuddin commentedReroll patch -- 0kb for some reason
Comment #6
lokapujyaThanks for reviewing. Patch fixed.
Comment #7
lokapujyaComment #8
mcpuddin CreditAttribution: mcpuddin commentedapplied patch, tested views, worked well! After robot thing goes through ready to go in!
Comment #10
lokapujya#6: 2002972-rename-views-method.patch queued for re-testing.
Comment #11
elvis2 CreditAttribution: elvis2 commentedYou need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.
You can see an example patch here: http://drupal.org/node/2001672
Comment #12
tvlooy CreditAttribution: tvlooy commentedAdded the access modifiers.
Comment #13
elvis2 CreditAttribution: elvis2 commented@tvlooy thanks for working on this.
I went ahead and re-rolled the patch since there were other instances of tokenize_value() being used. I believe you only checked the views module? When we rename the functions we need to grep across the whole drupal_root directory. Sometimes other modules run tests that reference functions that do not belong to the module calling the function.
Comment #15
elvis2 CreditAttribution: elvis2 commented#13: 2002972-13-rename-views-method.patch queued for re-testing.
Comment #16
lokapujyaThe patch in #13 changes 2 instances of render_trim_text to RenderTrimText which is actually handled by a separate issue. The patch in #12 is the correct patch.
Comment #17
elvis2 CreditAttribution: elvis2 commented@lokapujya I apologize about that, I must have not reset the git repo before making the patch.
The reason I rolled #13 was because #12 was missing a few renames of tokenize_value(). So #12 and #13 need to be rerolled. If this is not rerolled by this evening I will work on it.
Thanks for catching the problem.
Comment #18
oenie CreditAttribution: oenie commentedUnfortunately we need a reroll to the newest Drupal core as well, the patch doesn't apply anymore.
Comment #19
lokapujyaRe-rolled. I found 11 instances of tokenize_value(). They were all within the Views module.
Comment #20
elvis2 CreditAttribution: elvis2 commented@lokapujya thanks for re-rolling. Looks good.
Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696
Comment #21
alexpottNeeds a reroll
Comment #22
jibranReroll
Comment #23
lokapujyaGTG.
Comment #24
alexpottCommitted 8612773 and pushed to 8.x. Thanks!