Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#15 | 2003350-15-rename-render_altered.patch | 1.44 KB | elvis2 |
#13 | 2003350-13-rename-render_altered.patch | 1.44 KB | elvis2 |
#9 | 2003350-9.patch | 1.42 KB | jibran |
#4 | views-rename_function-2003350-4.patch | 1.42 KB | tvlooy |
#2 | views-rename_function-2003350-2.patch | 1.42 KB | druderman |
Comments
Comment #1
druderman CreditAttribution: druderman commentedAt drupalcon sprint
Comment #2
druderman CreditAttribution: druderman commentedComment #3
elvis2 CreditAttribution: elvis2 commentedThanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.
You can see an example patch here: http://drupal.org/node/2001672
Comment #4
tvlooy CreditAttribution: tvlooy commentedAdded the access modifier.
Comment #5
elvis2 CreditAttribution: elvis2 commentedLooks good.
Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696
Comment #6
druderman CreditAttribution: druderman commentedGood catch. Thanks Tvlooy.
Comment #7
druderman CreditAttribution: druderman commentedComment #8
alexpottNeeds re-roll
Comment #9
jibranReroll
conflict
resolved
Comment #11
druderman CreditAttribution: druderman commented#9: 2003350-9.patch queued for re-testing.
Comment #12
dawehnerIt's just used internally, so it should be marked as protected.
Comment #13
elvis2 CreditAttribution: elvis2 commentedRe-rolled based on most recent pull of 8.x branch.
Edit: please cancel this patch, if possible, since it has an error in the code.
Comment #14
dawehnerShould be protected
Comment #15
elvis2 CreditAttribution: elvis2 commentedThanks @dawehner. Re-rolled.
Comment #16
dawehnerThank you!
Comment #17
alexpottCommitted 49fb3c5 and pushed to 8.x. Thanks!