Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 commented
Title: Convert views_ajax() to a new style controller » Convert variable_get() to a new style controller
Component: views.module » system.module
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Fixed

variable_get() is just a plain old function which will be removed by CMI.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Title: Convert variable_get() to a new style controller » Convert VariableTest to a
Status: Fixed » Active

Tim showed me http://api.drupal.org/api/drupal/core!modules!system!tests!modules!syste... which had all this page callbacks.

I think what we should do instead is to rewrite the tests instead.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Title: Convert VariableTest to a » Convert VariableTest to a more unit-like test
damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

CMI will test this stuff pretty extensively, no?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Fixed

Well, just in general variable-get tests don't have to be converted at all, so let's skip it.

Automatically closed -- issue fixed for 2 weeks with no activity.