Rename Views method operator_form to operatorForm() [#2003438]

Comment	File	Size	Author
#10	drupal-viewsRename-operator_form-2003438-10.patch.patch	5.78 KB	heddn

#8	rename_operator_form-2003438-8.patch	4.43 KB	trevjs

#6	rename_operator_form-2003438-6.patch	4.71 KB	trevjs

#1	8.x-dev-rename_operator_form.patch	640 bytes	trevjs

File	Size
8.x-dev-rename_operator_form.patch	640 bytes

Comment #2

trevjs CreditAttribution: trevjs commented 24 May 2013 at 19:41

Status:

Active

» Needs review

Log in or register to post comments

Comment #3

trevjs CreditAttribution: trevjs commented 24 May 2013 at 19:42

Assigned:

trevjs

» Unassigned

Log in or register to post comments

Comment #4

25 May 2013 at 01:02

Status:

Needs review

» Needs work

The last submitted patch, 8.x-dev-rename_operator_form.patch, failed testing.

Log in or register to post comments

Comment #5

trevjs CreditAttribution: trevjs commented 28 May 2013 at 16:13

Assigned:

Unassigned

» trevjs

Log in or register to post comments

Comment #6

trevjs CreditAttribution: trevjs commented 28 May 2013 at 16:42

Status:

Needs work

» Needs review

File	Size
rename_operator_form-2003438-6.patch	4.71 KB

Forgot to change callers. Also specified public calling method. In some cases it is called by show_operator_form, and so it may be that this is intended to be a private method. Let me know and I'll change it.

Log in or register to post comments

Comment #7

29 May 2013 at 00:15

Status:

Needs review

» Needs work

The last submitted patch, rename_operator_form-2003438-6.patch, failed testing.

Log in or register to post comments

Comment #8

trevjs CreditAttribution: trevjs commented 30 May 2013 at 20:04

Status:

Needs work

» Needs review

File	Size
rename_operator_form-2003438-8.patch	4.43 KB

Re-roll

Log in or register to post comments

Comment #9

oenie CreditAttribution: oenie commented 2 June 2013 at 06:40

Status:

Needs review

» Needs work

Hate to throw this back again, but it seems you have missed a spot:

core/modules/search/lib/Drupal/search/Plugin/views/filter/Search.php, line 51:
function operator_form(&$form, &$form_state) {

Be sure to add the access modifier in front of the function as well.
Actually, since the only call to the operatorForm method seem to be on a $this instance, it could actually be protected instead of public.