Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#3 rename-condition-namespace-2002430-1.patch1.66 KBhugo.lallo
#1 rename-condition-namespace-2002430.patch1.65 KBhugo.lallo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hugo.lallo’s picture

hugo.lallo CreditAttribution: hugo.lallo commented
Status: Active » Needs review
FileSize
rename-condition-namespace-2002430.patch1.65 KB
oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.phpundefined
@@ -329,7 +329,7 @@ function alter_subquery_condition(AlterableInterface $query, &$conditions) {
+  function conditionNamespace($string) {

Add protected access modifier in front of the functions to adher to the new OOP standards.

hugo.lallo’s picture

hugo.lallo CreditAttribution: hugo.lallo commented
FileSize
rename-condition-namespace-2002430-1.patch1.66 KB
hugo.lallo’s picture

hugo.lallo CreditAttribution: hugo.lallo commented
Status: Needs work » Needs review
oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Reviewed & tested by the community

Looks fine by me !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 875ee5c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.