Rename Views method lgtm() to useStringGroupBy() [#2002946]

Comment	File	Size	Author
#6	drupal-rename-use_string_group_by-views-2002946-6.patch	1.8 KB	mari3.14

#5	drupal-rename-use_string_group_by-views-2002946-5.patch	1.41 KB	mari3.14

#2	drupal-rename-use_string_group_by-2002946-2.patch	1.78 KB	malcomio

Comment #1

malcomio CreditAttribution: malcomio commented 24 May 2013 at 18:38

Assigned:

Unassigned

» malcomio

Log in or register to post comments

Comment #2

malcomio CreditAttribution: malcomio commented 24 May 2013 at 18:54

Status:

Active

» Needs review

File	Size
drupal-rename-use_string_group_by-2002946-2.patch	1.78 KB

Log in or register to post comments

Comment #3

25 May 2013 at 00:38

Status:

Needs review

» Needs work

The last submitted patch, drupal-rename-use_string_group_by-2002946-2.patch, failed testing.

Log in or register to post comments

Comment #4

aspilicious CreditAttribution: aspilicious commented 25 May 2013 at 11:01

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -402,7 +402,7 @@ function get_value($values, $field = NULL) {
+  function useStringGroupBy() {

Should be "public function useString..."

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -402,7 +402,7 @@ function get_value($values, $field = NULL) {
\ No newline at end of file

A file always need to end with a newline

Log in or register to post comments

Comment #5

mari3.14 CreditAttribution: mari3.14 commented 26 May 2013 at 16:55

Status:

Needs work

» Needs review

File	Size
drupal-rename-use_string_group_by-views-2002946-5.patch	1.41 KB

Log in or register to post comments

Comment #6

mari3.14 CreditAttribution: mari3.14 commented 26 May 2013 at 19:40

File	Size
drupal-rename-use_string_group_by-views-2002946-6.patch	1.8 KB

Patch on #5 is incomplete, please see here a new patch with all the changes necessary.

Log in or register to post comments

Comment #7

oenie CreditAttribution: oenie commented 28 May 2013 at 23:47

Title:	Rename Views method use_string_group_by() to useStringGroupBy()	» Rename Views method lgtm() to useStringGroupBy()
Status:	Needs review	» Reviewed & tested by the community

Looks good to me now !