_filter_xss_attributes is a bit hard to read because things aren't setup at the top but in the middle of the code.

This patch adds a sane default value for $skip.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Active » Needs review
FileSize
371 bytes

So here is the patch, it's definitive really minor.

iStryker’s picture

Status: Needs review » Reviewed & tested by the community

This is a very old patch.

> git apply -v --index 1398044-skip-default.patch
Checking patch core/includes/common.inc...
Hunk #1 succeeded at 1124 (offset -334 lines).
Applied patch core/includes/common.inc cleanly.

Patch is good and doesn't break anything.

iStryker’s picture

Title: Provide default value for $skip in _filter_xss_attributes » Provide default value for $skip in XSS Component
Status: Reviewed & tested by the community » Needs review
Issue tags: +Novice
FileSize
481 bytes

May 28th, #1998466: Convert filter_xss_admin and similar function to an Xss component was committed which broke this patch. Re-rolling...

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Cool.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice

The last submitted patch, drupal-skip_default-1398044-3.patch, failed testing.

dawehner’s picture

Status: Needs work » Needs review

#3: drupal-skip_default-1398044-3.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, drupal-skip_default-1398044-3.patch, failed testing.

iStryker’s picture

Status: Needs work » Needs review
Issue tags: +Novice

#3: drupal-skip_default-1398044-3.patch queued for re-testing.

bradwade’s picture

Assigned: Unassigned » bradwade

Will reroll

bradwade’s picture

Rerolled #3

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

+1

webchick’s picture

Category: feature » task
Status: Reviewed & tested by the community » Fixed

Looks good to me. Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.