Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#26 | vdc-2002918-26.patch | 1.3 KB | tim.plunkett |
#23 | 2002918-rename-get_items.patch | 2.04 KB | sillygwailo |
#21 | 2002918-rename-get_items.patch | 2.03 KB | sillygwailo |
#18 | 2002918-18.patch | 2.03 KB | jibran |
#12 | 2002918-rename-get_items.patch | 2.03 KB | sillygwailo |
Comments
Comment #1
sillygwailobaldwinlouie and I are taking this one.
Comment #2
sillygwailoHere's a patch.
Comment #3
sillygwailoComment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedGoing to re-roll.
Comment #6
Anonymous (not verified) CreditAttribution: Anonymous commentedI rolled a new patch and added the public keyword to the function, per the feedback on this issue: http://drupal.org/node/2002460
Comment #8
oenie CreditAttribution: oenie commentedTo avoid confusion over the previous patches, i'm rerolling patch #2 with corrections on the acces modifiers for the changed functions.
Comment #9
oenie CreditAttribution: oenie commentedComment #10
heddnNeeds a re-roll.
$ git apply 2002918-rename-get_items-3.patch
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php:1110
error: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php: patch does not apply
Comment #11
sillygwailoRe-rolled against 8.x. Might need another re-roll when the advanced_render() change is committed.
Comment #12
sillygwailoPatch attached.
Comment #14
sillygwailo#12: 2002918-rename-get_items.patch queued for re-testing.
Comment #15
aspilicious CreditAttribution: aspilicious commented:D thnx!
Comment #16
somepal CreditAttribution: somepal commentedreviewed and checked all the calls. gtg with #12 2002918-rename-get_items.patch
Comment #17
alexpottNeeds a reroll
Comment #18
jibranRe-roll
Conflict
Resolved
Comment #19
aspilicious CreditAttribution: aspilicious commentedprotected function getItems($values) {
Comment #20
oenie CreditAttribution: oenie commentedComment #21
sillygwailoRe-rolled with protected in the PrerenderList.php.
Comment #23
sillygwailoRe-roll.
Comment #24
dawehnerPerfect
Comment #25
alexpottCommitted ac6bbe4 and pushed to 8.x. Thanks!
Comment #26
tim.plunkettI started porting FullCalendar to D8, and this bit me hard.
I remember adding this method to D7 so contrib could use it.
It very much needs to be public.
Comment #27
aspilicious CreditAttribution: aspilicious commentedComment #28
alexpottCommitted a24345a and pushed to 8.x. Thanks!