Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#9 | 8.x-rename-views-method-2002900-9.patch | 5.22 KB | diarmy |
#7 | 8.x-rename-views-method-2002900-7.patch | 5.24 KB | diarmy |
#7 | interdiff.txt | 683 bytes | diarmy |
#3 | 8.x-rename-views-method-2002900-3.patch | 5.23 KB | diarmy |
#3 | interdiff.txt | 1014 bytes | diarmy |
Comments
Comment #1
diarmy CreditAttribution: diarmy commentedWorking on it!
Comment #2
diarmy CreditAttribution: diarmy commentedComment #3
diarmy CreditAttribution: diarmy commentedThe patch in #2 did not take into account instances of get_default_argument() used outside of the views module. After grepping the whole site, another example was located in core/modules/user/lib/Drupal/user/Tests/Views/ArgumentDefaultTest.php. This updated patch includes the conversion to getDefaultArgument for this too.
Comment #5
diarmy CreditAttribution: diarmy commented#3: 8.x-rename-views-method-2002900-3.patch queued for re-testing.
Comment #6
diarmy CreditAttribution: diarmy commentedJust realised that I need to add the public modifier before function getDefaultArgument() to adhere to OOP standards, so I'll get cracking with that.
Comment #7
diarmy CreditAttribution: diarmy commentedThis version includes the public modifier before function getDefaultArgument() in core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php.
Comment #8
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adhere to the new OOP standards.
Comment #9
diarmy CreditAttribution: diarmy commentedI started over again, this time remembering to add the public access modifier in front of the function.
Comment #10
diarmy CreditAttribution: diarmy commentedUpdating status to needs review
Comment #11
dawehnerCool.
Comment #12
alexpottCommitted 0449064 and pushed to 8.x. Thanks!