Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#16 | replace_theme_drupal_render_views_ui-2006974-16.patch | 7.99 KB | jlbellido |
#8 | 2006974-8.patch | 9.46 KB | thedavidmeister |
#8 | 2006974-interdiff-1-8.txt | 918 bytes | thedavidmeister |
#1 | 2006974-1.patch | 9.2 KB | thedavidmeister |
Comments
Comment #1
thedavidmeister CreditAttribution: thedavidmeister commentedpatch
Comment #3
thedavidmeister CreditAttribution: thedavidmeister commented#1: 2006974-1.patch queued for re-testing.
Comment #5
c4rl CreditAttribution: c4rl commentedRetitiling
Comment #6
thedavidmeister CreditAttribution: thedavidmeister commented#1: 2006974-1.patch queued for re-testing.
Comment #8
thedavidmeister CreditAttribution: thedavidmeister commentedComment #9
thedavidmeister CreditAttribution: thedavidmeister commentedComment #10
kay_v CreditAttribution: kay_v commentedComment #11
kay_v CreditAttribution: kay_v commentedComment #12
jenlamptonNot sure why this one is marked needs manual testing, there's no twig files in here to test. Just removed calls to theme? What needs manual testing?
Comment #13
adamcowboy CreditAttribution: adamcowboy commentedI applied the patch and added a new view. Everything looks fine.
Comment #14
thedavidmeister CreditAttribution: thedavidmeister commented@jenlampton - I was told in IRC that "everything Views related had to be manually tested as different issues had broken the UI a few times before"
Comment #15
alexpottNeeds a reroll...
Comment #16
jlbellidoRe rolled, i have tested manually and it looks fine. Removed tag and running test for this re-roll.
Comment #17
adamcowboy CreditAttribution: adamcowboy commentedApplied the patch and tested. Everything looks fine. The previous guy manually tested it and he did good work.
Comment #18
alexpottCommitted e36b512 and pushed to 8.x. Thanks!