I asked for Mail Editor module support here: #1878340: Privatemsg support but the developer told me:

Mail Editor is ready for every client module that wants to use it.

So I guess the support must be given by you. Any chances?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

odizle’s picture

any news about this? I would also like to have this option. My use case is that I need to make Hebrew templates with the RTL writing directions.

ptmkenny’s picture

What exactly is required to support Mail Editor? Is there something that Privatemsg does in a non-standard way that needs to be fixed? Otherwise, based on the Mail Editor maintainer's post, Privatemsg should be compatible.

warmth’s picture

No idea, I'm just reporting what I have been told. I hope you can figure it out because it will be a great addition.

salvis’s picture

Look at the mail_edit/modules directory for examples.

ptmkenny’s picture

Status: Active » Needs review
FileSize
1.57 KB

Ok, here's a tentative patch that adds a new submodule offering integration based on the logintoboggan example. Let me know if it works for you.

ptmkenny’s picture

Version: 7.x-1.3 » 7.x-2.x-dev

Status: Needs review » Needs work

The last submitted patch, privatemsg-mail-edit-integration-submodule-1878642-5.patch, failed testing.

ptmkenny’s picture

Status: Needs work » Needs review
mrded’s picture

Status: Needs review » Needs work

I got the warning then I try to apply patch:

➤ git apply --index privatemsg-mail-edit-integration-submodule-1878642-5.patch
privatemsg-mail-edit-integration-submodule-1878642-5.patch:65: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
mrded’s picture

+++ b/privatemsg_mail_edit/privatemsg_mail_edit.module
@@ -0,0 +1,46 @@
+function privatemsg_mailkeys() {
...
+function privatemsg_mail_edit_text($mailkey, $language) {
...
+function privatemsg_mail_edit_token_types($mailkey) {

Why do you use hooks from another module? O_o

+++ b/privatemsg_mail_edit/privatemsg_mail_edit.module
@@ -0,0 +1,46 @@
+  if (module_exists('privatemsg')) {

What is the reason to check module? This module is in dependencies.

+++ b/privatemsg_mail_edit/privatemsg_mail_edit.module
@@ -0,0 +1,46 @@
+    return user_mailkeys() + array(
+      'pm_email_notify' => t('Privatemsg e-mail notifications'),
+    );

privatemsg module has 'pm_email_notify' key only.

I guess that this patch will never works.

ptmkenny’s picture

Ok, I don't really understand how to integrate with Mail Editor then. @mrded Please supply your own patch if you find a way to get it working.

mrded’s picture

Status: Needs work » Needs review
FileSize
3.83 KB

Please, take a look my patch.

mrded’s picture

Priority: Normal » Major
Issue summary: View changes

Any progress, guys?

mrded’s picture

mrded’s picture

12: privatemsg-1878642-12.patch queued for re-testing.

ivnish’s picture

Status: Needs review » Closed (outdated)
andypost’s picture

Status: Closed (outdated) » Needs review

D7 is not yet outdated