Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#12 | rename_views_method-2003496-12.patch | 39.84 KB | marlatt |
#12 | interdiff.txt | 617 bytes | marlatt |
#9 | rename_views_method-2003496-9.patch | 39.89 KB | marlatt |
#4 | Rename_Views_method-2003496-4.patch | 11.81 KB | NonProfit |
#2 | Rename_Views_method-2003496-2.patch | 17.04 KB | NonProfit |
Comments
Comment #1
NonProfit CreditAttribution: NonProfit commentedComment #2
NonProfit CreditAttribution: NonProfit commentedPatch created.
Comment #3
NonProfit CreditAttribution: NonProfit commentedNeed to reroll. get_value_options() improperly changed .
Comment #4
NonProfit CreditAttribution: NonProfit commentedPatch created.
Comment #6
heddnComment #7
dawehnerNeeds an access modifier.
Comment #8
marlatt CreditAttribution: marlatt commentedWorking..
Comment #9
marlatt CreditAttribution: marlatt commentedPrevious patch would not apply, no interdiff created. All methods updated and access modifiers created.
Comment #10
dawehnerLet's do an @inheritdoc ... well at it should have been FieldPluginBase :) but just here for now
Comment #11
dawehnerComment #12
marlatt CreditAttribution: marlatt commentedI hope this is correct, I'm still getting to know some of the best practices. I apologize ahead of time.
Comment #13
marlatt CreditAttribution: marlatt commentedChanging status.
Comment #14
dawehnerPlease don't apologize! It's just a code review :)
Comment #15
webchickCommitted and pushed to 8.x. Thanks!
Moving to the Views queue for the change notice.
Comment #16
xjmWe'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.