Rename Views method block_display_options() to blockDisplayOptions() [#2002366]

Comment	File	Size	Author
#5	views-core-blockDisplayOptions-2002366-05.patch	3.61 KB	SpartyDan

#2	2002366-2-rename_blockDisplayOptions.patch	3.52 KB	Gung Wang

Comment #1

Gung Wang CreditAttribution: Gung Wang commented 24 May 2013 at 17:47

Assigned:

Unassigned

» Gung Wang

I take it.

Log in or register to post comments

Comment #2

Gung Wang CreditAttribution: Gung Wang commented 24 May 2013 at 22:47

Status:

Active

» Needs review

File	Size
2002366-2-rename_blockDisplayOptions.patch	3.52 KB

Uploaded the patch.

Log in or register to post comments

Comment #3

elvis2 CreditAttribution: elvis2 commented 28 May 2013 at 03:14

Should the access modifier on this function be public?

Log in or register to post comments

Comment #4

heddn

English

Nicaragua

CreditAttribution: heddn commented 28 May 2013 at 13:18

If the method is only used internally i.e. $this->{foo}, then I'd recommend protected. Otherwise, go with public as it needs to be usable by folks outside the class is apart of the public API.

Log in or register to post comments

Comment #5

SpartyDan CreditAttribution: SpartyDan commented 30 May 2013 at 03:59

File	Size
views-core-blockDisplayOptions-2002366-05.patch	3.61 KB

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/wizard/Comment.php
@@ -113,8 +113,8 @@ protected function page_display_options(array $form, array &$form_state) {
   /**
    * Overrides Drupal\views\Plugin\views\wizard\WizardPluginBase::page_display_options().
    */

Corrected error in documentation page_display_options should be block_display_options which is updated by this patch to be blockDisplayOptions

Updates from patch in comment #2 are also included in this patch.