Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima’s picture

Assigned: Unassigned » phenaproxima
phenaproxima’s picture

Assigned: phenaproxima » Unassigned
Status: Active » Needs review
FileSize
1.78 KB
oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/style/Table.phpundefined
@@ -185,7 +185,7 @@ function build_sort_post() {
+  function sanitizeColumns($columns, $fields = NULL) {

Add public access modifier in front of the function to adhere to the new OOP standards.

All occurrences are replaced, so the corrected patch should be RTBC.

SpartyDan’s picture

Status: Needs work » Needs review
FileSize
1.78 KB

Added public access modifier in front of the function to adhere to the new OOP standards.

Status: Needs review » Needs work

The last submitted patch, views-core-rename-sanitize_columns-2003310-04.patch, failed testing.

SpartyDan’s picture

Status: Needs work » Needs review
FileSize
1.79 KB

re-rolled

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Cool

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 9ae13bc and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.