Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comments
Comment #1
zhgenti CreditAttribution: zhgenti commentedComment #2
zhgenti CreditAttribution: zhgenti commentedComment #4
zhgenti CreditAttribution: zhgenti commentedComment #6
oenie CreditAttribution: oenie commentedAll occurences replaced; correct the issue below.
Add public access modifier in front of the function to adhere to the new OOP standards.
Comment #7
zhgenti CreditAttribution: zhgenti commentedIssue in #6 addressed
Comment #9
zhgenti CreditAttribution: zhgenti commented#7: rename-views-method-get_offset-to-getoffset-2002968-6.patch queued for re-testing.
Comment #10
oenie CreditAttribution: oenie commentedIs there a specific reason why you have put an access modifier in front of set_items_per_page ?
Because that is part of a different rename, and might give clashes with #2003282: Rename Views method set_items_per_page() to setItemsPerPage()
Comment #11
dawehnerSo clearly needs work :(
Comment #12
zhgenti CreditAttribution: zhgenti commentedIsn't it what you suggested in comment #6? I probably misunderstood something :(
Comment #13
heddnfunction getOffset()
should be public. Also, I noticed that when you re-rolled the patch in #6 you rolled and interdiff, not a diff from HEAD.Comment #14
zhgenti CreditAttribution: zhgenti commentedWhat a shame ( I looked at the different function in the comment 6... Should be fine now, also rolled over HEAD
Comment #15
dawehnerPerfect.
Comment #16
webchickCommitted and pushed to 8.x. Thanks!
Moving to Views for the change notice.
Comment #17
xjmWe'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.
Comment #18
xjmOops.