Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#9 views-rename_render_as_link-2003348-9.patch1.38 KBJeroenT
#7 views-core-renderAsLink-2003348-07.patch1.38 KBSpartyDan
#4 views-renderAsLink-2003348-4.patch1.37 KBJeroenT
#2 views-2003348-renderAsLink.patch1.36 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima commented
Assigned: phenaproxima » Unassigned
Status: Active » Needs review
FileSize
views-2003348-renderAsLink.patch1.36 KB

Patch passed all field handler tests on my localhost.

Status: Needs review » Needs work

The last submitted patch, views-2003348-renderAsLink.patch, failed testing.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Needs work » Needs review
FileSize
views-renderAsLink-2003348-4.patch1.37 KB

Rename render_as_link function to renderAsLink.

oenie’s picture

oenie CreditAttribution: oenie commented

Unfortunately, the patch doesn't apply anymore.
You'll need to reroll it.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Needs work
SpartyDan’s picture

SpartyDan CreditAttribution: SpartyDan commented
Status: Needs work » Needs review
FileSize
views-core-renderAsLink-2003348-07.patch1.38 KB

re-rolled

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work

I consider this as a usecase for protected.

JeroenT’s picture

JeroenT
Primary language Dutch
Location 🇧🇪
CreditAttribution: JeroenT commented
Status: Needs work » Needs review
FileSize
views-rename_render_as_link-2003348-9.patch1.38 KB

Added protected access modifier as mentioned by dawehner.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Thank you very much.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 631d0da and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.