Rename Views method op_simple() to opSimple() [#2003522]

Comment	File	Size	Author
#11	views-rename_op_simple-2003522-11.patch	4.17 KB	JeroenT

#8	drupal_rename_op_simple-2003522-8.patch	4.15 KB	nathangervais

#5	views-rename_op_simple-2003522-5.patch	4.23 KB	JeroenT

#2	rename_op_simple.patch	2.46 KB	trevjs

Comment #1

trevjs CreditAttribution: trevjs commented 24 May 2013 at 20:00

Assigned:

Unassigned

» trevjs

Log in or register to post comments

File	Size
rename_op_simple.patch	2.46 KB

Comment #3

munizjor CreditAttribution: munizjor commented 24 May 2013 at 20:50

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Date.phpundefined
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Date.phpundefined
@@ -178,7 +178,7 @@ function op_between($field) {

@@ -178,7 +178,7 @@ function op_between($field) {
+  function addSimpleQuery($field) {

functions needs to be public.

Log in or register to post comments

Comment #4

25 May 2013 at 01:04

Status:

Needs review

» Needs work

The last submitted patch, rename_op_simple.patch, failed testing.

Log in or register to post comments

Comment #5

JeroenT

Dutch

🇧🇪

CreditAttribution: JeroenT commented 27 May 2013 at 12:45

Status:

Needs work

» Needs review

File	Size
views-rename_op_simple-2003522-5.patch	4.23 KB

Rename op_simple() to addSimpleQuery().

Log in or register to post comments

Comment #6

aspilicious CreditAttribution: aspilicious commented 29 May 2013 at 11:23

Status:

Needs review

» Reviewed & tested by the community

Done

Log in or register to post comments

Comment #7

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 29 May 2013 at 22:42

Status:

Reviewed & tested by the community

» Needs work

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opSimple (we should also drop the Query as it is not a Query - it appears to add a comparison operator)