Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#11 | views-rename_op_simple-2003522-11.patch | 4.17 KB | JeroenT |
#8 | drupal_rename_op_simple-2003522-8.patch | 4.15 KB | nathangervais |
#5 | views-rename_op_simple-2003522-5.patch | 4.23 KB | JeroenT |
#2 | rename_op_simple.patch | 2.46 KB | trevjs |
Comments
Comment #1
trevjs CreditAttribution: trevjs commentedComment #2
trevjs CreditAttribution: trevjs commentedComment #3
munizjor CreditAttribution: munizjor commentedfunctions needs to be public.
Comment #5
JeroenTRename op_simple() to addSimpleQuery().
Comment #6
aspilicious CreditAttribution: aspilicious commentedDone
Comment #7
alexpottIn #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opSimple (we should also drop the Query as it is not a Query - it appears to add a comparison operator)
Comment #8
nathangervais CreditAttribution: nathangervais commentedRerolled patch to rename op_simple to opSimple
Comment #9
heddnFixing title
Comment #10
aspilicious CreditAttribution: aspilicious commentedTalkes with dawehner about this, should be protected. Srry!
Comment #11
JeroenTChanged access modifier to protected as mentioned by aspilicious.
Comment #12
dawehnerNo calls are left and code looks fine.
Comment #13
alexpottCommitted 35a7926 and pushed to 8.x. Thanks!