Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
drupal_container() is deprecated, and all calls in the breakpoint module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154)
Comment | File | Size | Author |
---|---|---|---|
#13 | 2003260-replace-drupal_container-breakpoint-module-13.patch | 2.31 KB | kgoel |
#13 | interdiff.txt | 1.28 KB | kgoel |
#8 | 2003260-replace-drupal_container-breakpoint-module.patch | 1.67 KB | ddrozdik |
#5 | 2003260-replace-drupal_container-breakpoint-module.patch | 1.63 KB | ddrozdik |
#3 | 2003260-3.patch | 1.38 KB | ebeyrent |
Comments
Comment #1
ebeyrent CreditAttribution: ebeyrent commentedComment #2
ebeyrent CreditAttribution: ebeyrent commentedComment #3
ebeyrent CreditAttribution: ebeyrent commentedComment #4
ddrozdik CreditAttribution: ddrozdik commentedpatch #3 looks good, but last time was lots of commits, and need re-test.
Comment #5
ddrozdik CreditAttribution: ddrozdik commentedCreated a new patch for whole task.
Removed @todo from install file, because that task already closed.
Also the best way to use moduleHandler via Drupal::moduleHandler() not Drupal::service('module_handler') as in patch #2
Comment #6
podarok#5 looks good
RTBC
Comment #7
alexpottNeeds a reroll
Comment #8
ddrozdik CreditAttribution: ddrozdik commentedComment #9
ddrozdik CreditAttribution: ddrozdik commentedComment #10
Crell CreditAttribution: Crell commentedAnd again.
Comment #11
YesCT CreditAttribution: YesCT commentedThis issue was RTBC and passing tests on July 1, the beginning of API freeze.
Comment #12
alexpottThere are other deprecated functions called in breakpoint.module... config() and entity_get_info() which are both wrappers to container services... and have \Drupal equivalents...
Comment #13
kgoel CreditAttribution: kgoel commentedComment #14
Crell CreditAttribution: Crell commentedIf the bot approves...
Comment #16
kgoel CreditAttribution: kgoel commented#13: 2003260-replace-drupal_container-breakpoint-module-13.patch queued for re-testing.
Comment #17
Crell CreditAttribution: Crell commentedSigh, testbot.
Comment #18
webchickCommitted and pushed to 8.x. Thanks!
Comment #19.0
(not verified) CreditAttribution: commentedUpdated issue summary.