Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comments
Comment #1
phenaproximaComment #2
phenaproximaPatch passed all argument and argument validator tests on my localhost...EXCEPT for the date argument handler test. However, that test fails even with the patch not applied, so I think that must be different issue.
Comment #3
elvis2 CreditAttribution: elvis2 commentedThanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.
You can see an example patch here: http://drupal.org/node/2001672
Comment #4
phenaproximaAdded the public modifier to all the functions in the patch.
Comment #5
phenaproxima...and marking as needing review. :)
Comment #6
oenie CreditAttribution: oenie commentedLooks fine to me !
Comment #7
oenie CreditAttribution: oenie commentedAnd thanks elvis2 for helping out ... paying it forward rocks ! :)
Comment #8
alexpottNeeds a re-roll
Comment #9
jibranreroll
conflict
resolved like this
Comment #11
elvis2 CreditAttribution: elvis2 commentedComment #12
jibran#9: 2003356-9.patch queued for re-testing.
Comment #14
drupalway CreditAttribution: drupalway commentedWe are working today with this issue during Code Sprint UA
Comment #15
drupalway CreditAttribution: drupalway commentedRe-rolled. Please review.
Comment #17
SpartyDan CreditAttribution: SpartyDan commentedRe-rolled
Comment #18
heddnLooks good.
Comment #19
aspilicious CreditAttribution: aspilicious commentedagree :)
Comment #20
alexpottCommitted da83b1a and pushed to 8.x. Thanks!