Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
drupal_container() is deprecated, and all calls in the comment module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154)
Comment | File | Size | Author |
---|---|---|---|
#38 | comment-2003498-38.patch | 2.98 KB | herom |
#34 | comment-2003498-34.patch | 3.87 KB | LinL |
#32 | drupal8.comment-module.2003498-32.patch | 5.87 KB | disasm |
#32 | interdiff.txt | 1.23 KB | disasm |
#27 | comment-2003498-27.patch | 5.12 KB | kgoel |
Comments
Comment #1
ebeyrent CreditAttribution: ebeyrent commentedComment #3
ddrozdik CreditAttribution: ddrozdik commentedAdded some modifications to previous patch and also changed module_exists() to Drupal::moduleHandler()->moduleExists()
Comment #4
tstoecklerIn these two the leading \ could actually be omitted.
It's not wrong in any way though (I just think we loosely agreed on omitting in procedural code), so marking RTBC anyway.
Comment #5
ddrozdik CreditAttribution: ddrozdik commentedtstoeckler, ok, fixed in this patch
Comment #6
tstoecklerYay! +1
Comment #7
alexpottNo longer applies
Comment #8
ddrozdik CreditAttribution: ddrozdik commentedComment #9
tstoecklerLooks good.
Comment #10
webchickThis no longer applies for me.
Comment #11
pwieck CreditAttribution: pwieck commentedRe-rolled @webchick this reroll successfully applied to today's build. Hope it passes.
Comment #12
tstoecklerYup.
Comment #13
alexpottI think these can be injected into the plugin because it extends Drupal\views\Plugin\views\PluginBase
Should use $this->container->get
Comment #14
porchlight CreditAttribution: porchlight commentedThe patch no longer applied. Heres the reroll
Comment #15
tstoecklerStill needs work for #13.
Comment #16
kgoel CreditAttribution: kgoel commentedTook care of this.
This was already implemented in core/modules/comment/lib/Drupal/comment/Tests/CommentFieldsTest.php.
Comment #17
ebeyrent CreditAttribution: ebeyrent commentedLooks good to me.
Comment #18
alexpottNeeds reroll...
Comment #19
Gaelan CreditAttribution: Gaelan commentedRerolled. alexpott: BTW this was my reroll script. :)
Comment #20
kgoel CreditAttribution: kgoel commentedComment #21
Crell CreditAttribution: Crell commentedAnd back.
Comment #22
catch#19: comment.dic_move.2003498.19.patch queued for re-testing.
Comment #24
kgoel CreditAttribution: kgoel commentedComment #25
Crell CreditAttribution: Crell commentedBot can object.
Comment #26
alexpottFor some reason there we're adding an unnecessary use
Comment #27
kgoel CreditAttribution: kgoel commentedComment #28
Crell CreditAttribution: Crell commentedComment #29
alexpottPatch no longer applies.
Comment #30
star-szrTag fix, WSSCI -> WSCCI.
Comment #31
star-szrSorry for the noise, didn't check autocomplete.
Comment #32
disasm CreditAttribution: disasm commentedreroll! Also, replacing global $user with Drupal::currentUser() in comment.module as well.
Comment #34
LinL CreditAttribution: LinL commentedRe-rolled from #27 as the change to global user in #32 looks like scope creep? (And it's being done in #2061899: Remove references to global $user in Comment module)
Comment #35
LinL CreditAttribution: LinL commentedTag fix.
Comment #36
jibranAnd back to RTBC.
Comment #37
alexpottPatch no longer applies.
Comment #38
herom CreditAttribution: herom commentedRerolled.
Some of the changes were already fixed in HEAD. so, the patch size is smaller.
Comment #39
tstoecklerLooks good.
Comment #40
Crell CreditAttribution: Crell commentedLet's just get this in.
Comment #41
tstoeckler#38: comment-2003498-38.patch queued for re-testing.
Comment #42
catchCommitted/pushed to 8.x, thanks!