There's broken usage of $this->container in forum tests, probably typo

CommentFileSizeAuthor
#5 2010250-forum-container-5.patch707 bytesandypost
#1 2010250-forum-container-1.patch1.06 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Active » Needs review
FileSize
2010250-forum-container-1.patch1.06 KB

Also a bit of clean-up

Status: Needs review » Needs work
Issue tags: -Quick fix, -CodeSprintUA

The last submitted patch, 2010250-forum-container-1.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs work » Needs review

#1: 2010250-forum-container-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Quick fix, +CodeSprintUA

The last submitted patch, 2010250-forum-container-1.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Title: Do not destroy $this->container in form tests » clean-up useless assign in forum test
Status: Needs work » Needs review
FileSize
2010250-forum-container-5.patch707 bytes

re-focus

enhdless’s picture

enhdless CreditAttribution: enhdless commented

Patch works great.
Should probably check the rest of the code for similar problems.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

@enhdless Makes sense, but I found not other troubles. Feel free to rtbc the issue once patch applies cleanly

enhdless’s picture

enhdless CreditAttribution: enhdless commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Thanks @andypost

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

5: 2010250-forum-container-5.patch queued for re-testing.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Priority: Normal » Minor

Thanks @andypost.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.