Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#17 | 2002348-rename-advanced_render.patch | 35.61 KB | sillygwailo |
#8 | drupal-camelcase-2002348.8.patch | 33.65 KB | baldwinlouie |
#5 | drupal-camelcase-2002348-v2.patch | 33.64 KB | baldwinlouie |
#2 | drupal-camelcase-removal-2002348-7449008.patch | 36.31 KB | baldwinlouie |
Comments
Comment #1
baldwinlouie CreditAttribution: baldwinlouie commentedclaimed by baldwinlouie and sillygwailo
Comment #2
baldwinlouie CreditAttribution: baldwinlouie commentedattaching the patch
Comment #3
baldwinlouie CreditAttribution: baldwinlouie commentedsetting to needs review
Comment #5
baldwinlouie CreditAttribution: baldwinlouie commentedrerolled the patch
Comment #6
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adher to the new OOP standards.
Comment #7
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adher to the new OOP standards.
Comment #8
baldwinlouie CreditAttribution: baldwinlouie commentedrerolled with access modifier
Comment #9
baldwinlouie CreditAttribution: baldwinlouie commentedchanging back to needs review
Comment #10
oenie CreditAttribution: oenie commentedLooks fine by me now.
Comment #11
alexpottA new test has been added that uses the advanced_render method...
Drupal\file\Tests\Views\ExtensionViewsFieldTest
Comment #12
heddn#8: drupal-camelcase-2002348.8.patch queued for re-testing.
Comment #14
heddnLet's try actually updating the test first... before we run testbot.
Comment #15
aspilicious CreditAttribution: aspilicious commentedLooks ok
Comment #16
alexpottPatch no longer applies...
Comment #17
sillygwailoRe-rolled.
Comment #18
aspilicious CreditAttribution: aspilicious commentedComment #19
webchickCommitted and pushed to 8.x. Thanks!
Moving to Views for the change notice.
Comment #20
xjmWe'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.