part of #2011290: [meta] standards cleanup to get ready for getting into core
Problem/Motivation
unused use statement
unused variable $depth
line line function summaries must be 80 chars or less. (core gate blocker https://drupal.org/core-gates#documentation-block-requirements)
@todo formatting https://drupal.org/node/1354#todo
Helper function...
@return needs descriptions (core gate blocker)
Proposed resolution
update according to standards
change Helper function... one line descriptions to Returns... for one line function summary should start with third person verb.
take out fun Goddamn ugly... one line function summary phrases.
Remaining tasks
patch
User interface changes
No.
API changes
No.
Comment | File | Size | Author |
---|---|---|---|
#4 | config_translation.module.2011348-4.patch | 6.81 KB | YesCT |
#4 | interdiff-1-4.txt | 499 bytes | YesCT |
#1 | config_translation.module.2011348.1.patch | 6.91 KB | YesCT |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedComment #2
YesCT CreditAttribution: YesCT commenteddo we need to open an issue to do this now that 1905152 is fixed?
Comment #3
Gábor Hojtsy@YesCT re #2, that was #1936186: Make use of locale API when it becomes available where we decided not to do it since it would have ended up with specialized code for some stuff. So this comment should be removed. Otherwise looks good to me.
Comment #4
YesCT CreditAttribution: YesCT commentedremoved comment.
Comment #5
Gábor HojtsyLooks great now, thanks, committed/pushed.
Comment #6.0
(not verified) CreditAttribution: commentednote which are blockers to getting into core