Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#15 | rename_views_method-2003536-15.patch | 2.62 KB | marlatt |
#15 | interdiff.txt | 2.09 KB | marlatt |
#12 | drupal_rename_op_regex-2003536-12.patch | 2.61 KB | nathangervais |
#10 | drupal_rename_op_regex-2003536-10.patch | 2.61 KB | nathangervais |
#7 | interdiff.txt | 2.24 KB | marlatt |
Comments
Comment #1
toddtomlinson CreditAttribution: toddtomlinson commentedComment #2
sassafrass CreditAttribution: sassafrass commentedComment #3
sassafrass CreditAttribution: sassafrass commentedComment #4
NonProfit CreditAttribution: NonProfit commentedComment #5
NonProfit CreditAttribution: NonProfit commentedPatch created.
Comment #7
marlatt CreditAttribution: marlatt commentedUpdated access modifiers, re-rolled patch.
Comment #8
aspilicious CreditAttribution: aspilicious commentedDone
Comment #9
alexpottIn #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opRegex()
Comment #10
nathangervais CreditAttribution: nathangervais commentedRerolled patch to rename op_regex to opRegex
Comment #11
aspilicious CreditAttribution: aspilicious commentedpublic?
Comment #12
nathangervais CreditAttribution: nathangervais commentedRerolled patch to add missing public access modifier
Comment #13
aspilicious CreditAttribution: aspilicious commentedComment #14
aspilicious CreditAttribution: aspilicious commentedTalkes with dawehener about this, should be protected. Srry!
Comment #15
marlatt CreditAttribution: marlatt commentedChanged method access to protected from public.
Comment #16
aspilicious CreditAttribution: aspilicious commentedThnx!
Comment #17
oenie CreditAttribution: oenie commentedChanging the title to avoid confusion. op_xxx methods will be renamed to opXxxx instead of addXxx
Comment #18
webchickNoticed these op_XX functions are all missing doxygen, but xjm told me that's getting taken care of as part of #1856544: [META] Views documentation improvements.
Committed and pushed to 8.x. Thanks!
Moving to Views for the change notice.
Comment #19
xjmWe'll create a single change notice in the meta.