Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Status: Active » Needs review
FileSize
101.14 KB

First extract, let's see if I got everything I need.

Status: Needs review » Needs work

The last submitted patch, use-entity-test-2004224-1.patch, failed testing.

Berdir’s picture

Status: Needs work » Needs review
FileSize
2.08 KB
103.23 KB

This should fix those tests.

Status: Needs review » Needs work
Issue tags: -sprint, -Entity Field API

The last submitted patch, use-entity-test-2004224-3.patch, failed testing.

Berdir’s picture

Status: Needs work » Needs review

#3: use-entity-test-2004224-3.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +sprint, +Entity Field API

The last submitted patch, use-entity-test-2004224-3.patch, failed testing.

andypost’s picture

+++ b/core/modules/field/lib/Drupal/field/Tests/FieldTestBase.phpundefined
@@ -49,9 +49,13 @@ function _generateTestFieldValues($cardinality) {
+    entity_get_controller($entity->entityType())->resetCache(array($entity->id()));
 * @deprecated Use \Drupal\Core\Entity\EntityManager::getStorageController().
 */
function entity_get_controller($entity_type) {
  return Drupal::entityManager()
    ->getStorageController($entity_type);

andypost’s picture

Status: Needs work » Needs review
Issue tags: +CodeSprintUA
FileSize
100.96 KB
1.97 KB

re-roll with small changes

andypost’s picture

proper merge

andypost’s picture

Drupal\field\Tests\FormTest still broken, @Berdir I cant fix that

Berdir’s picture

Yeah, that's because the method that I changed is also used there and it's used with the old entity type that's not yet NG.

One possible way to fix this would be to keep and override of that method in FormTest, with a @todo to kill it when no longer necessary.

Status: Needs review » Needs work

The last submitted patch, use-entity-test-2004224-9.patch, failed testing.

Berdir’s picture

Status: Needs work » Needs review
FileSize
4.37 KB
101.85 KB

Something like this. Also removing the EntityTestCache class, I don't think we need this one here.

andypost’s picture

Status: Needs review » Reviewed & tested by the community

So now it works!

Berdir’s picture

Priority: Normal » Major

This is part of a critical issue and blocking the @yched's field api/typed data issue, so raising to major to give it some visibility.

swentel’s picture

This is almost critical imo, because we need #1822000: Remove Drupal\field_test\Plugin\Entity\Type\TestEntity in favor of EntityTest after that and then we can (finally) start on #1953408: Remove ArrayAccess BC layer from field config entities (which is also critical).

Berdir’s picture

#13: use-entity-test-2004224-13.patch queued for re-testing.

alexpott’s picture

Needs a reroll

curl https://drupal.org/files/use-entity-test-2004224-13_0.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  101k  100  101k    0     0  43713      0  0:00:02  0:00:02 --:--:-- 51861
error: patch failed: core/modules/link/lib/Drupal/link/Tests/LinkFieldTest.php:185
error: core/modules/link/lib/Drupal/link/Tests/LinkFieldTest.php: patch does not apply
alexpott’s picture

Status: Reviewed & tested by the community » Needs work
Berdir’s picture

Status: Needs work » Needs review
FileSize
101.85 KB

Here it is.

Berdir’s picture

Issue tags: +Field API NG blocker

Starting to use that tag for things we need to do to complete conversion, remove BC layer and fully convert field API to Entity Field API/Typed data.

yched’s picture

Issue tags: -Field API NG blocker

Green, back to RTBC ?

Berdir’s picture

Issue tags: +Field API NG blocker

Re-adding tag.

swentel’s picture

Status: Needs review » Reviewed & tested by the community
yched’s picture

Yeah, meant to do that in #22, but instead I removed the tag :-D Sorry folks.
Let's get this in !

yched’s picture

yched’s picture

#20: use-entity-test-2004224-20.patch queued for re-testing.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed bf2c404 and pushed to 8.x. Thanks!

Berdir’s picture

Automatically closed -- issue fixed for 2 weeks with no activity.