drupal_container() is deprecated, and all calls in the path module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154: Replace calls to drupal_container()->get('module_handler') service with Drupal::moduleHandler())

CommentFileSizeAuthor
#4 path-2011116-4.patch7.42 KBkgoel
#4 interdiff.txt3.16 KBkgoel
#2 path-2011116-2.patch7.39 KBkgoel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kgoel’s picture

kgoel CreditAttribution: kgoel commented
Assigned: Unassigned » kgoel
kgoel’s picture

kgoel CreditAttribution: kgoel commented
Status: Active » Needs review
FileSize
path-2011116-2.patch7.39 KB
dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Needs work

It looks like there are a lot of calls in PathAliasTest.php that need to be converted to this->container->get().

kgoel’s picture

kgoel CreditAttribution: kgoel commented
Status: Needs work » Needs review
FileSize
interdiff.txt3.16 KB
path-2011116-4.patch7.42 KB
dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

#4 looks good. The patch converts all uses of drupal_container() in the path module.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

ddrozdik’s picture

ddrozdik CreditAttribution: ddrozdik commented
Status: Fixed » Closed (fixed)