Support from Acquia helps fund testing for Drupal Acquia logo

Comments

markie’s picture

Assigned: Unassigned » markie
Status: Active » Needs review
FileSize
2.82 KB

three files patched

mcpuddin’s picture

Status: Needs review » Reviewed & tested by the community

Applied the patch, tested out views, and nothing broke. I wasn't able to find the exact trigger for this function, but it looked fairly well!

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, rename_setWhereGroup-2003270-1.patch, failed testing.

markie’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, rename_setWhereGroup-2003270-1.patch, failed testing.

heddn’s picture

Failing tests. Please test and re-roll.

SpartyDan’s picture

Status: Needs work » Needs review
FileSize
2.82 KB

Re-rolled

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-core-set_where_group-2003270-7.patch, failed testing.

markie’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, views-core-set_where_group-2003270-7.patch, failed testing.

markie’s picture

Status: Needs work » Needs review
FileSize
2.83 KB

rerolled against fresh pull.

Status: Needs review » Needs work

The last submitted patch, views_rename_setWhereGroup-2003270-11.patch, failed testing.

markie’s picture

Status: Needs work » Needs review
FileSize
2.83 KB

rerolled

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views_rename_setWhereGroup-2003270-12.patch, failed testing.

markie’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

needs reroll

curl https://drupal.org/files/views_rename_setWhereGroup-2003270-12.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2894  100  2894    0     0   3897      0 --:--:-- --:--:-- --:--:--  5077
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php:962
error: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php: patch does not apply
jibran’s picture

Status: Needs work » Needs review
FileSize
2.52 KB

reroll

Status: Needs review » Needs work

The last submitted patch, 2003270-18.patch, failed testing.

markie’s picture

Status: Needs work » Needs review
FileSize
2.52 KB

re-re-roll

dcam’s picture

Status: Needs review » Reviewed & tested by the community

#20 looks good to me. All instances of the method name have been rewritten. The method visibility is set to public.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 9048d3b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.