Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#20 | drupal_core-views-rename_setWhereGroup-2003270-20.patch | 2.52 KB | markie |
#18 | 2003270-18.patch | 2.52 KB | jibran |
#13 | views_rename_setWhereGroup-2003270-12.patch | 2.83 KB | markie |
#11 | views_rename_setWhereGroup-2003270-11.patch | 2.83 KB | markie |
#7 | views-core-set_where_group-2003270-7.patch | 2.82 KB | SpartyDan |
Comments
Comment #1
markie CreditAttribution: markie commentedthree files patched
Comment #2
mcpuddin CreditAttribution: mcpuddin commentedApplied the patch, tested out views, and nothing broke. I wasn't able to find the exact trigger for this function, but it looked fairly well!
Comment #4
markie CreditAttribution: markie commented#1: rename_setWhereGroup-2003270-1.patch queued for re-testing.
Comment #6
heddnFailing tests. Please test and re-roll.
Comment #7
SpartyDan CreditAttribution: SpartyDan commentedRe-rolled
Comment #9
markie CreditAttribution: markie commented#7: views-core-set_where_group-2003270-7.patch queued for re-testing.
Comment #11
markie CreditAttribution: markie commentedrerolled against fresh pull.
Comment #13
markie CreditAttribution: markie commentedrerolled
Comment #15
markie CreditAttribution: markie commented#13: views_rename_setWhereGroup-2003270-12.patch queued for re-testing.
Comment #16
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #17
alexpottneeds reroll
Comment #18
jibranreroll
Comment #20
markie CreditAttribution: markie commentedre-re-roll
Comment #21
dcam CreditAttribution: dcam commented#20 looks good to me. All instances of the method name have been rewritten. The method visibility is set to public.
Comment #22
alexpottCommitted 9048d3b and pushed to 8.x. Thanks!