Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
That's just a small bit to decouple and make it phpunitestable.
Comment | File | Size | Author |
---|---|---|---|
#30 | date-2003934-30.patch | 6.58 KB | tim.plunkett |
#25 | 2003934-25.patch | 6.59 KB | damiankloip |
#25 | interdiff-2003934-25.txt | 609 bytes | damiankloip |
#23 | 2003934-23.patch | 6.58 KB | damiankloip |
#23 | interdiff-2003934-23.txt | 616 bytes | damiankloip |
Comments
Comment #1
dawehner#1998466: Convert filter_xss_admin and similar function to an Xss component is the only global dependency which blocks from convering to unit tests.
Comment #3
dawehnerComment #4
dawehner#3: drupal-2003934-2.patch queued for re-testing.
Comment #5
dawehnerJust a rerole.
Comment #7
dawehner#5: drupal-2003934-5.patch queued for re-testing.
Comment #9
dawehnerLet's fix the failures.
Comment #10
ParisLiakos CreditAttribution: ParisLiakos commentedwhy not name the service date? then we can add more helper methods in the future
we can inject language manager here and use instead
Comment #12
tim.plunkett#9: drupal-2003934-9.patch queued for re-testing.
Comment #13
dawehnerYeah why not.
Comment #15
damiankloip CreditAttribution: damiankloip commentedRerolled and injected the language manager.
Comment #17
tim.plunkett#15: 2003934-15.patch queued for re-testing.
Comment #19
dawehnerLet's use a central config variable.
Comment #20
ParisLiakos CreditAttribution: ParisLiakos commentedok sorry for this, but i just saw DrupalDateTime object..and i am sitting here and wondering why this logic shouldnt be in DrupalDateTime::format since it is the drupal specific object?
so i can do:
or even introduce a create() method to make this oneliner...
Comment #21
tim.plunkettNo, we don't want to do that because of #2003892: Convert date formats to config entities
Comment #23
damiankloip CreditAttribution: damiankloip commentedWe have a mismatch of service names.
Comment #25
damiankloip CreditAttribution: damiankloip commentedSorry, totally put the wrong constant in the language change :)
That nicely vouches for the test coverage I guess.
Comment #26
dawehnerNice! Not everything is views btw. :)
Comment #27
ParisLiakos CreditAttribution: ParisLiakos commentedlooks great to me:) thanks!
Comment #28
alexpottNeeds reroll
Comment #29
alexpottComment #30
tim.plunkettThis patch and #2004506: Move standard_country_list() to Drupal\Core\Locale\Country both tried to add a service to the end of the core.services.yml.
Since it was just a failing of git and absolutely nothing changed, I'm reRTBCing.
Please don't credit me in the commit message.
Comment #31
alexpottCommitted 0bfe623 and pushed to 8.x. Thanks!