Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
#1893906: Move views argument date handlers from node module changed the date argument handlers from node_created_* to date_* however, when these got changed the created_year_month got changed to date_year_month, which is wrong. This needs to stay as created (like all the others) but use the date_year_month plugin.
Comment | File | Size | Author |
---|---|---|---|
#28 | 1960888-28.patch | 3.37 KB | jibran |
#28 | interdiff.txt | 1021 bytes | jibran |
#26 | 1960888-26.patch | 3.09 KB | jibran |
#25 | 1960888-25.patch | 3.09 KB | jibran |
#25 | interdiff.txt | 728 bytes | jibran |
Comments
Comment #1
olli CreditAttribution: olli commentedMakes sense. Test?
Comment #2
tim.plunkettMarked #1972282: 'Missing handler: node created_year_month argument' as a dupe, working on a test.
Comment #3
tim.plunkettHere's a test.
Comment #4
damiankloip CreditAttribution: damiankloip commentedThis seems a bit confusing with the DefaultViewsTest(s) couldn't testArchiveView just move into Drupal\views\Tests\DefaultViewsTest?
I don't think we do anywhere else, but maybe drupal_map_assoc() instead? Not sure if there is any point though - Just would make it slightly easier to read imo.
Comment #5
tim.plunkettComment #6
dawehnerLet's do that.
Comment #7
damiankloip CreditAttribution: damiankloip commentedThis looks good now. Let's wait for the bot.
Comment #8
olli CreditAttribution: olli commentedComment #9
alexpottNeeds reroll
Comment #10
jibranFixed this
with this
Comment #11
jibranComment #12
klonosThe patch fixes #1975642: Cannot edit views - 'edit' button leads to WSOD (fresh installation).
Comment #13
dawehner+1
Comment #14
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #15
alexpottThis unfortunately broke head...
Reverted with commit 6801679 and pushed to 8.x.
Comment #16
jibran#10: 1960888-10.patch queued for re-testing.
Comment #18
jibranFixed the test.
Comment #19
jibranFull stop missing. :/
Comment #20
damiankloip CreditAttribution: damiankloip commentedThis change looks good. let's get confirmation from the bot. Then I think this can be RTBC again.
Comment #21
tim.plunkettCame back green, thanks for fixing that @jibran!
Comment #22
dawehnerOh wow ... this code would have passed in the last month but then started to fail.
Comment #23
dawehnerIgnore my patch as it is pretty much the same fix, not even better.
Comment #24
olli CreditAttribution: olli commentedRe #19
This should be 'Ym', but in general, why use time() instead of a fixed timestamp also in the setup method?
Comment #25
jibranFixed #24.
Comment #26
jibranIgnore last patch wrong rebase.
Comment #27
dawehnerSo yeah let's use REQUEST_TIME for consistency as it also fixes some random fails.
Comment #28
jibranLet's do it.
Comment #29
olli CreditAttribution: olli commentedThat's a good idea, and great work jibran!
Comment #30
alexpottCommitted aba632c and pushed to 8.x. Thanks!