Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lieb’s picture

Assigned: Unassigned » lieb

Assigned to myself - working on now.

brennanmh’s picture

Assigned: lieb » Unassigned
Status: Active » Needs review
FileSize
2.01 KB

# modified: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php
# modified: core/modules/views/views.theme.inc
#

brennanmh’s picture

Oops, sorry. It was unassigned when I started.

Status: Needs review » Needs work

The last submitted patch, element_label_type-rename-2002474.patch, failed testing.

brennanmh’s picture

Assigned: Unassigned » brennanmh

Took ownership.

heddn’s picture

No longer applies. Re-rolled.

heddn’s picture

Status: Needs work » Needs review
FileSize
3.24 KB

interdiff is backwards in #6. Here's a corrected diff.

The changed in #6 adds public to elementLabelType() and fixed a couple places where calls to elementLabelType() weren't renamed.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Looking good

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4c40f82 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.